-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove unnecessary use of jquery on the recaptcha page. #11406
Conversation
Signed-off-by: ankur12-1610 <anknerd.12@gmail.com>
Signed-off-by: ankur12-1610 <anknerd.12@gmail.com>
@@ -0,0 +1 @@ | |||
Removes unnecessary use of jquery on the recaptcha page from `synapse/synapse/res/templates/recaptcha.html`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will mean much to the average synapse admin. It would be better to say where this page is used.
I believe it's the fallback page for clients which don't support recaptcha themselves? Have you been able to test it, at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richvdh I ran the local server but I'm unable to test it, I'm unable to find the correct path of the page.
This is the url http://localhost:8080/_matrix/static/
what should be the path to append if I want to test this feature? :' )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://localhost:8008/_matrix/client/v3/auth/m.login.recaptcha/fallback/web?session=abc is the location of the recaptcha fallback page, which should load the contents of the configured recaptcha.html
template.
This was a discussion on how to test this manually locally in #synapse-dev here: https://matrix.to/#/!XaqDhxuTIlvldquJaV:matrix.org/$xWMp0Ah_BKfWz9IxE7uUP2Tpzanem6hdDJjRaxsXGNI?via=matrix.org&via=vector.modular.im&via=envs.net
I'm going to close this due to lack of response. @ankur12-1610 if you're interested in working on this again please shout and we can reopen! 👍 |
Signed-off-by: ankur12-1610 anknerd.12@gmail.com
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)
Fixes: #11308