Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove unnecessary use of jquery on the recaptcha page. #11406

Closed
wants to merge 3 commits into from
Closed

Remove unnecessary use of jquery on the recaptcha page. #11406

wants to merge 3 commits into from

Conversation

ankur12-1610
Copy link

@ankur12-1610 ankur12-1610 commented Nov 22, 2021

Signed-off-by: ankur12-1610 anknerd.12@gmail.com

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

Fixes: #11308

Signed-off-by: ankur12-1610 <anknerd.12@gmail.com>
@ankur12-1610 ankur12-1610 requested a review from a team as a code owner November 22, 2021 12:57
Signed-off-by: ankur12-1610 <anknerd.12@gmail.com>
@richvdh richvdh changed the title Removed unnecessary use of jquery on the recaptcha page. Remove unnecessary use of jquery on the recaptcha page. Nov 22, 2021
synapse/res/templates/recaptcha.html Show resolved Hide resolved
changelog.d/11406.bugfix Outdated Show resolved Hide resolved
@clokep clokep requested a review from richvdh November 23, 2021 12:20
@@ -0,0 +1 @@
Removes unnecessary use of jquery on the recaptcha page from `synapse/synapse/res/templates/recaptcha.html`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will mean much to the average synapse admin. It would be better to say where this page is used.

I believe it's the fallback page for clients which don't support recaptcha themselves? Have you been able to test it, at all?

Copy link
Author

@ankur12-1610 ankur12-1610 Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richvdh I ran the local server but I'm unable to test it, I'm unable to find the correct path of the page.
error

This is the url http://localhost:8080/_matrix/static/ what should be the path to append if I want to test this feature? :' )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://localhost:8008/_matrix/client/v3/auth/m.login.recaptcha/fallback/web?session=abc is the location of the recaptcha fallback page, which should load the contents of the configured recaptcha.html template.

This was a discussion on how to test this manually locally in #synapse-dev here: https://matrix.to/#/!XaqDhxuTIlvldquJaV:matrix.org/$xWMp0Ah_BKfWz9IxE7uUP2Tpzanem6hdDJjRaxsXGNI?via=matrix.org&via=vector.modular.im&via=envs.net

@anoadragon453 anoadragon453 added the X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged label Dec 1, 2021
@clokep
Copy link
Member

clokep commented Jun 1, 2022

I'm going to close this due to lack of response. @ankur12-1610 if you're interested in working on this again please shout and we can reopen! 👍

@clokep clokep closed this Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary use of jquery on the recaptcha page
4 participants