Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Reverse-proxy configuration problem: _synapse is also neccesary #8154

Closed
OmmyZhang opened this issue Aug 24, 2020 · 4 comments · Fixed by #8227
Closed

Reverse-proxy configuration problem: _synapse is also neccesary #8154

OmmyZhang opened this issue Aug 24, 2020 · 4 comments · Fixed by #8227
Assignees
Labels
A-Docs things relating to the documentation z-p2 (Deprecated Label)

Comments

@OmmyZhang
Copy link
Contributor

Not only _matrix but _synapse is also used. (for oidc login)
I suggest to use location /_ { in examples.

@ser
Copy link

ser commented Aug 25, 2020

I really do not understand why reverse proxy documentation does not include _synapse/.

Are there any security reasons?

@richvdh
Copy link
Member

richvdh commented Aug 26, 2020

One reason not to include /_synapse/ in these lists is to avoid exposing the admin apis by default.

Having discussed this, we should:

  • have oidc use a path under /_synapse/client
  • document that /_synapse/client should be forwarded by the reverse-proxy
  • we can also mention that /_synapse/admin may optionally be forwarded.

@babolivier babolivier added A-Docs things relating to the documentation z-p2 (Deprecated Label) labels Aug 26, 2020
@clokep
Copy link
Member

clokep commented Sep 10, 2020

One reason not to include /_synapse/ in these lists is to avoid exposing the admin apis by default.

Having discussed this, we should:

* have oidc use a path under `/_synapse/client`

* document that `/_synapse/client` should be forwarded by the reverse-proxy

* we can also mention that `/_synapse/admin` may optionally be forwarded.

@anoadragon453 It looks like #8227 only did the documentation piece. Did the OIDC path need to be moved?

@anoadragon453
Copy link
Member

@clokep Yes it does, though I'm not sure if this issue is the best place to continue tracking it. I can open a new issue specifically for that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docs things relating to the documentation z-p2 (Deprecated Label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants