This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Audit and/or add validation to endpoints in synapse/rest/client/account.py #13183
Description
Processed
- EmailPasswordRequestTokenRestServlet
- PasswordRestServlet
- DeactivateAccountRestServlet
- EmailThreepidRequestTokenRestServlet
- MsisdnThreepidRequestTokenRestServlet
- AccountStatusRestServlet
- The above covered by A second batch of Pydantic models for rest/client/account.py #13687
- ThreepidAddRestServlet
- ThreepidBindRestServlet
- ThreepidUnbindRestServlet
- ThreepidDeleteRestServlet
- The above covered by A third batch of Pydantic validation for rest/client/account.py #13736
Todo
- AddThreepidMsisdnSubmitTokenServlet
- The above covered by Last batch of Pydantic for synapse/rest/client/account.py #13832
No action
- AddThreepidEmailSubmitTokenServlet, GET only
- WhoamiRestServlet, GET only
- ThreepidRestServlet
- GET: nothing to do
- Going to ignore POST body: it's deprecated and seemingly unused
Metadata
Metadata
Assignees
Labels
Most users are unlikely to come across this or unexpected workflowMinor significance, cosmetic issues, low or no impact to users.Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Makes developers' lives better, but doesn't have direct user impactWe know exactly how to fix this issue, and would be grateful for any contribution