Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum Synapse version in README.md #10

Merged
merged 1 commit into from
May 3, 2022
Merged

Update minimum Synapse version in README.md #10

merged 1 commit into from
May 3, 2022

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented May 2, 2022

In #6 was added a dependency for matrix-synapse >= 1.57.0

[options.extras_require]
dev =
# for tests
matrix-synapse >= 1.57.0

I do not know what happens if you call a module API call that does not exists in Synapse.
There is no try ... catch

@dklimpel dklimpel requested a review from a team as a code owner May 2, 2022 11:31
@DMRobertson
Copy link

I wonder if that dependency on synapse should just be listed as a dependency of the module as a whole, rather than a dev-only extra?

Copy link

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Dirk, thank you!

@DMRobertson DMRobertson changed the title Fix correct Synapse Version in README.md Update minimum Synapse version in README.md May 3, 2022
@DMRobertson DMRobertson merged commit 56bfeb2 into matrix-org:main May 3, 2022
@dklimpel dklimpel deleted the patch-1 branch May 3, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants