Set the DM flag on new DMs #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
force-pushed
the
rei/set_dm_flag
branch
2 times, most recently
from
b06b2b4
to
5871b09
Compare
Closed
reivilibre
force-pushed
the
rei/set_dm_flag
branch
from
e6feb12
to
a89ca9f
Compare
reivilibre
force-pushed
the
rei/set_dm_flag
branch
from
b3d4a64
to
04717f6
Compare
reivilibre
force-pushed
the
rei/set_dm_flag
branch
from
04717f6
to
8179f16
Compare
erikjohnston
approved these changes
Apr 8, 2022
setup.cfg
Outdated
| @@ -17,7 +17,7 @@ python_requires = >= 3.7 | |||
| [options.extras_require] | |||
| dev = | |||
| # for tests | |||
| matrix-synapse | |||
| matrix-synapse @ git+https://github.com/matrix-org/synapse.git@rei/modapi_acc_data | |||
There was a problem hiding this comment.
Should we be specifying a minimum bound of Synapse somewhere?
There was a problem hiding this comment.
Good point, I'll add that in
There was a problem hiding this comment.
Is there a reason we're specifying the version bound as an optional dev-only extra rather than as a hard requirement on the package?
There was a problem hiding this comment.
I think this version bound is purely so linters pass (since I assume the module relies on changes that weren't already merged into develop or released in a stable version of Synapse at the time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5.
Requires the module API added in matrix-org/synapse#12391 (likely to land in v1.57.0).
This work is sponsored. It should be possible to review commit-by-commit.