Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update @vector-im/compound-design-tokens #12876

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Aug 8, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

The changes:

@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 8, 2024
@@ -6946,14 +6946,6 @@ matrix-widget-api@^1.8.2:
"@types/events" "^3.0.0"
events "^3.2.0"

matrix-widget-api@^1.8.2:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate. Already present line 6941.

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking visual nit

@florianduros
Copy link
Contributor Author

florianduros commented Aug 8, 2024

@robintown also the mx_Heading_h4 heading is a lot bigger now. It doesn't looking really good in the right header playwright/snapshots/polls/polls.spec.ts/ThreadView-with-a-poll-on-group-layout-linux.png for example.

I wonder what is the best approach:

  • Change the heading to body-lg-semibold
  • Or only change in right header

@robintown
Copy link
Member

I think the current pattern in which h1, h2, h3, h4 map directly to our heading/xl, heading/lg, heading/md, heading/sm design tokens is pretty nice. If we keep wanting to use body/* tokens as headers, that's an indication that we should change something about our design system IMO. Germain noticed this too: element-hq/compound#154

@florianduros
Copy link
Contributor Author

I think the current pattern in which h1, h2, h3, h4 map directly to our heading/xl, heading/lg, heading/md, heading/sm design tokens is pretty nice. If we keep wanting to use body/* tokens as headers, that's an indication that we should change something about our design system IMO. Germain noticed this too: element-hq/compound#154

Hmmm you're right. I have the feeling that we are missing smaller tokens for heading. Maybe that's why designers are using body token for small headers.

Let's keep it in this state in this PR and we will have the conversation and update it if theses changes are not welcomed.

@florianduros florianduros added this pull request to the merge queue Aug 9, 2024
Merged via the queue into develop with commit 284cd40 Aug 9, 2024
29 checks passed
@florianduros florianduros deleted the florianduros/update-design-tokens branch August 9, 2024 12:47
@florianduros florianduros mentioned this pull request Aug 9, 2024
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants