Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review typography tokens for Web #154

Open
germain-gg opened this issue Jun 27, 2023 · 1 comment
Open

Review typography tokens for Web #154

germain-gg opened this issue Jun 27, 2023 · 1 comment
Assignees

Comments

@germain-gg
Copy link
Contributor

As part of the typography pass on Web, we've come to realise that the heading have a font-size of minimum 20px and above.

They are rather large which means we are using body tokens in a lot of places that are semantically tokens.

I would like to discuss this further as we should not be using body tokens as headings and vice versa

FAO @janogarcia and @nadonomy

@robintown
Copy link
Member

A simple solution might be to acknowledge that we like body/lg visually as a heading, and add a heading/xs token with the same value as it. (Though do we really need 5 heading levels? Another good question is whether we ever use body/lg as a non-heading.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants