Manually construct query strings for browser-request instances #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `request` just doesn't work for us in the browser, but `browser-request` is fine despite us having to do our own query strings. Fixes element-hq/element-web#7620
Member
Author
|
A proper solution would be element-hq/element-web#7634 however that is taking way too much time. |
turt2live
added a commit
to element-hq/element-web
that referenced
this pull request
Oct 31, 2018
This was introduced in matrix-org/matrix-react-sdk#2250 but can be pulled out due to matrix-org/matrix-js-sdk#770. See #7634 for more information about the future.
turt2live
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Oct 31, 2018
This was introduced in #2250 but can be pulled out due to matrix-org/matrix-js-sdk#770. See element-hq/element-web#7634 for more information about the future.
turt2live
added a commit
that referenced
this pull request
Oct 31, 2018
This was introduced in matrix-org/matrix-react-sdk#2250 but can be pulled out due to #770. See element-hq/element-web#7634 for more information about the future.
This was referenced Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
requestjust doesn't work for us in the browser, butbrowser-requestis fine despite us having to do our own query strings.Fixes element-hq/element-web#7620