Expose countSessionsNeedingBackup - #1429
Merged
Merged
Conversation
Useful to see the number of keys waiting for backup (it's exposed via events but you couldn;t get it directly). Also clarify doc on the return value of `flagAllGroupSessionsForBackup` which was not technically incorrect...
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jul 30, 2020
It always showed the warning (if you had at least one session key in your store) because flagAllGroupSessionsForBackup returns the number of keys pending backup after flagging them all for backup, ie. all of them. Seems like the intention was to only show the warning if there were keys that had not yet been backed up. Fixes element-hq/element-web#14829 Requires matrix-org/matrix-js-sdk#1429
turt2live
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful to see the number of keys waiting for backup (it's exposed
via events but you couldn't get it directly). Also clarify doc on
the return value of
flagAllGroupSessionsForBackupwhich was nottechnically incorrect...