Fix CallKit audio session late init #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com>
NicolasBuquet
force-pushed
the
fix-callkit-audio-session-late-init
branch
from
bc391f4
to
50dba6b
Compare
This was referenced Jun 19, 2024
Velin92
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in Element iOS : when the user answer a VoIP call from the "Answer" button in Element room timeline, very often, his correspondant can't hear him.
It's because the Audio Session is initialized too late. See https://developer.apple.com/forums/thread/64544 (7th post from Apple Engineer)
See this issue in Element Github: element-hq/element-ios#7721
See this issue in Tchap: tchapgouv/tchap-ios#1047
Pull Request Checklist