Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by ensuring gotestfmt is on PATH, plus cleanups #634

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Fix CI by ensuring gotestfmt is on PATH, plus cleanups #634

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae3d3fc
Use setup-go action
Apr 6, 2023
35a1a16
Bump checkout action
Apr 6, 2023
102ca4a
Check that gotestfmt is installed
Apr 6, 2023
1d9e633
`go install gotestfmt` instead of `go get`
Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check that gotestfmt is installed 
no `-version` flag, so `help` will have to do
  • Loading branch information
David Robertson committed Apr 6, 2023
commit 102ca4ab3293bc66ec18d4ef5f7f60ad2b39f1ed
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ jobs:
go get -v github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@latest
mkdir .gotestfmt/github -p
cp .ci/complement_package.gotpl .gotestfmt/github/package.gotpl
gotestfmt -help
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to fail fast if it doesn't exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly!


- name: "Checkout corresponding ${{ matrix.homeserver }} branch"
shell: bash
Expand Down