Fix CI by ensuring gotestfmt is on PATH, plus cleanups#634
Merged
DMRobertson merged 4 commits intomainfrom Apr 6, 2023
Merged
Conversation
added 4 commits
April 6, 2023 14:31
This was my first attempt to fix CI. Go 1.17 is no longer available on runners (actions/runner-images#7276 maybe) and I wondered if that might help with that. Unfortunately I think not. But we should get some go build caching as a side effect of using this action.
Drive-by fix for matrix-org/synapse#14203
no `-version` flag, so `help` will have to do
IDK why this suddenly started failing, but `go install` seems to put it on the PATH in a way that makes CI work.
DMRobertson
changed the title
gotestfmt is on PATH, plus cleanups
clokep
approved these changes
Apr 6, 2023
| run: | | ||
| sudo apt-get update && sudo apt-get install -y libolm3 libolm-dev | ||
| go get -v github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@latest | ||
| go install -v github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@latest |
Member
There was a problem hiding this comment.
Probably a version of go changing stuff?
Contributor
Author
There was a problem hiding this comment.
I think so. I didn't dig too hard here!
| go install -v github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@latest | ||
| mkdir .gotestfmt/github -p | ||
| cp .ci/complement_package.gotpl .gotestfmt/github/package.gotpl | ||
| gotestfmt -help |
Member
There was a problem hiding this comment.
This is just to fail fast if it doesn't exist?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for details.