-
Notifications
You must be signed in to change notification settings - Fork 14
Davidb/mpm #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Davidb/mpm #50
Changes from 40 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
7a12483
Only run deps install script on Linux
mcafaro 8a8f605
Add macOS and Windows to integ test matrix
mcafaro 2e54d2d
Add MATLAB bin folder to runner path after installation
mcafaro 8091c47
Merge pull request #23 from matlab-actions/windows-and-macos
mcafaro 1375ca6
Update vulnerable dependencies
mcafaro eef5296
Merge pull request #24 from matlab-actions/deps
mcafaro 50f16ad
1.1.0
25eb6fe
Bump minimist from 1.2.5 to 1.2.6
dependabot[bot] 55c576c
Use BSD license
mcafaro 40d866d
Merge pull request #36 from matlab-actions/bsd
mcafaro 7f1fdda
Merge pull request #34 from matlab-actions/dependabot/npm_and_yarn/mi…
davidbuzinski 46e7daa
1.1.1
2e665de
initial commit mpm
davidbuzinski ad431e0
fixing async issues
davidbuzinski 0a1176c
figuring out how actions cache paths works
davidbuzinski ddf6c8e
moving cache find inside mpm call
davidbuzinski 5099d96
trying once more with cache path
davidbuzinski f8c7a05
Add matlab-batch and --skip-activation (#40)
davidbuzinski f0e45fe
Update release process to automate semantic versioning (#41)
davidbuzinski 0b67291
[skip ci] Bump v1.2.0
ee31f66
linking to the run-build documentation (#43)
mw-hrastega a8893fd
Davidb/mpm (#45)
davidbuzinski bacc53a
fixing merge conflicts with main
davidbuzinski ae2ef07
Bump @actions/core from 1.4.0 to 1.9.1 (#42)
dependabot[bot] 63123b7
[skip ci] Bump v1.2.1
d7d39b6
Bump node version (#47)
davidbuzinski 71fedd9
[skip ci] Bump v1.2.2
07d2345
Update matlab.ts
davidbuzinski 9368315
bumping vulnerable dependencies (#49)
davidbuzinski 6c1f874
[skip ci] Bump v1.2.3
a71b1b7
cleaning up some syntax
davidbuzinski 703aa79
added new parameter to README
davidbuzinski 669ed9a
fixing broken build
davidbuzinski a8947ae
re-syncing recent dependency changes from main
davidbuzinski e5eb26e
oops forgot a git add
davidbuzinski f236f47
install MATLAB + PCT by default
davidbuzinski 57833da
fixing build
davidbuzinski 2c2b042
fixing assert in CI
davidbuzinski 164142e
address initial feedback
davidbuzinski 31283dc
fixing build
davidbuzinski 65ddcd5
Apply suggestions from code review
davidbuzinski f8a9aa5
changing version info to release info for consistency
davidbuzinski dc44c11
updating errors and README
davidbuzinski 3720cf8
Updating error text
davidbuzinski f873f22
Incorporating doc feedback
davidbuzinski 4baab09
updating README intro
davidbuzinski 6401472
updating examples
davidbuzinski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| name: Publish | ||
|
|
||
| on: | ||
| release: | ||
| types: [published, edited] | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| tag: ${{ steps.update-package-version.outputs.version }} | ||
| steps: | ||
| # Configure runner with the right stuff | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Configure git | ||
| run: | | ||
| git config user.name 'Release Action' | ||
| git config user.email '<>' | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16 | ||
|
|
||
| # Call `npm version`. It increments the version and commits the changes. | ||
| # We'll save the output (new version string) for use in the following | ||
| # steps | ||
| - name: Update package version | ||
| id: update-package-version | ||
| run: | | ||
| git tag -d "${{ github.event.release.tag_name }}" | ||
| VERSION=$(npm version "${{ github.event.release.tag_name }}" --no-git-tag-version) | ||
| echo "::set-output name=version::$VERSION" | ||
| git add package.json package-lock.json | ||
| git commit -m "[skip ci] Bump $VERSION" | ||
| git push origin HEAD:main | ||
|
|
||
| # Now carry on, business as usual | ||
| - name: Perform npm tasks | ||
| run: npm run ci | ||
|
|
||
| # Finally, create a detached commit containing the built artifacts and tag | ||
| # it with the release. Note: the fact that the branch is locally updated | ||
| # will not be relayed (pushed) to origin | ||
| - name: Commit to release branch | ||
| id: release_info | ||
| run: | | ||
| # Check for semantic versioning | ||
| echo "Preparing release for version $longVersion" | ||
| longVersion="${{github.event.release.tag_name}}" | ||
| [[ $longVersion == v[0-9]*.[0-9]*.[0-9]* ]] || (echo "must follow semantic versioning" && exit 1) | ||
| majorVersion=$(echo ${longVersion%.*.*}) | ||
| minorVersion=$(echo ${longVersion%.*}) | ||
|
|
||
| # Add the built artifacts. Using --force because dist/lib should be in | ||
| # .gitignore | ||
| git add --force dist lib | ||
|
|
||
| # Make the commit | ||
| MESSAGE="Build for $(git rev-parse --short HEAD)" | ||
| git commit --allow-empty -m "$MESSAGE" | ||
| git tag -f -a -m "Release $longVersion" $longVersion | ||
|
|
||
| # Get the commit of the tag you just released | ||
| commitHash=$(git rev-list -n 1 $longVersion) | ||
|
|
||
| # Delete the old major and minor version tags locally | ||
| git tag -d $majorVersion || true | ||
| git tag -d $minorVersion || true | ||
|
|
||
| # Make new major and minor version tags locally that point to the commit you got from the "git rev-list" above | ||
| git tag -f $majorVersion $commitHash | ||
| git tag -f $minorVersion $commitHash | ||
|
|
||
| # Force push the new minor version tag to overwrite the old tag remotely | ||
| echo "Pushing new tags" | ||
| git push -f origin $longVersion | ||
| git push -f origin $majorVersion | ||
| git push -f origin $minorVersion |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ## Contributing | ||
|
|
||
| Verify changes by running tests and building locally with the following command: | ||
|
|
||
| ``` | ||
| npm run ci | ||
| ``` | ||
|
|
||
| ## Creating a New Release | ||
|
|
||
| Familiarize yourself with the best practices for [releasing and maintaining GitHub actions](https://docs.github.com/en/actions/creating-actions/releasing-and-maintaining-actions). | ||
|
|
||
| Changes should be made on a new branch. The new branch should be merged to the main branch via a pull request. Ensure that all of the CI pipeline checks and tests have passed for your changes. | ||
|
|
||
| After the pull request has been approved and merged to main, follow the Github process for [creating a new release](https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository). The release must follow semantic versioning (ex: vX.Y.Z). This will kick off a new pipeline execution, and the action will automatically be published to the GitHub Actions Marketplace if the pipeline finishes successfully. Check the [GitHub Marketplace](https://github.com/marketplace/actions/setup-matlab) and check the major version in the repository (ex: v1 for v1.0.0) to ensure that the new semantically versioned tag is available. |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to stay on the mpm branch until out of beta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my initial thinking. I'm open to merging and using tags, but it seems like we might want to have easy access to make changes on v1 as needed for now too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I like keeping this on a branch until release. A lot of folks will look at the main branch README for doc, so we should probably keep any changes related to this beta out of the main branch README until release.