Davidb/mpm #50

davidbuzinski · 2022-11-08T14:04:27Z

MPM support for Linux and Windows. Leverage tool cache for install location

Add limited, undocumented, Windows and macOS support

Update vulnerable dependencies

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Use BSD license

…nimist-1.2.6 Bump minimist from 1.2.5 to 1.2.6

* skips ematlab activation if MATHWORKS env vars are set * added matlab-batch install

* update release.yml to update semantic versions

linking to the run-build documentation

merging from fork

Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.4.0 to 1.9.1. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) --- updated-dependencies: - dependency-name: "@actions/core" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

bumping action node version

.github/workflows/bat.yml

action.yml

mcafaro · 2022-11-08T19:27:05Z

README.md

-        uses: matlab-actions/setup-matlab@v1
-      - name: Run script
-        uses: matlab-actions/run-command@v1
+        uses: matlab-actions/setup-matlab@v2-beta


Is this going to stay on the mpm branch until out of beta?

That was my initial thinking. I'm open to merging and using tags, but it seems like we might want to have easy access to make changes on v1 as needed for now too.

Agreed. I like keeping this on a branch until release. A lot of folks will look at the main branch README for doc, so we should probably keep any changes related to this beta out of the main branch README until release.

src/matlab.ts

src/properties.json

action.yml

package.json

mcafaro · 2022-11-08T21:16:10Z

README.md

-        uses: matlab-actions/setup-matlab@v1
-      - name: Run script
-        uses: matlab-actions/run-command@v1
+        uses: matlab-actions/setup-matlab@v2-beta


Agreed. I like keeping this on a branch until release. A lot of folks will look at the main branch README for doc, so we should probably keep any changes related to this beta out of the main branch README until release.

README.md

src/matlab.ts

Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com>

README.md

src/matlab.ts

README.md

mw-hrastega · 2022-11-10T20:55:59Z

README.md

-| `release` | (Optional) MATLAB release to set up. You can specify R2020a or a later release. If you do not specify `release`, the action sets up the latest release of MATLAB.<br/>**Example**: `R2021a`
-
+| `release` | (Optional) MATLAB release to set up. You can specify R2020a or a later release. If you do not specify `release`, the action sets up the latest release of MATLAB.<br/>**Example**: `R2022a`
+| `products` | (Optional) Space-separated list of products to install. If a product name contains white-space characters, replace them with underscores. For the full list of available products and their names, see [Products and Services](https://www.mathworks.com/products.html). By default, the task installs MATLAB and the Parallel Computing Toolbox.<br/> **Example**: `MATLAB Simulink`


You say for a full list of products, see ...
Are transformational products also supported with mpm?

Yeah, transformational products are supported with mpm. They can install them with this action and provide their own matlab-batch token that we issued to them according to their license. Transformational products will not be licensed for Public repos though.

Ok. So any changes to this paragraph in the beta documentation?

https://github.com/matlab-actions/setup-matlab#:~:text=The%20Setup%20MATLAB%20action%20is%20not%20supported%20on%20self%2Dhosted%20runners.%20Currently%2C%20it%20is%20available%20only%20for%20public%20projects.%20It%20does%20not%20set%20up%20transformation%20products%2C%20such%20as%20MATLAB%20Coder%E2%84%A2%20and%20MATLAB%20Compiler%E2%84%A2.

The Setup MATLAB action is not supported on self-hosted runners. Currently, it is available only for public projects. It does not set up transformation products, such as MATLAB Coder™ and MATLAB Compiler™.

Good catch. I updated some of the text in the intro.

README.md

src/mpm.ts

README.md

* Invoke installer for private repo support * Disable automatic activation * Fix failing unit test to account for addition call * Add environment variables to workflow * Disable R2020a workflow; only R2020b for now * Build 82c7ee1 * Build for v1.0.1 * Remove -r from BaT workflow * First change * Use mpm * Update action.yml * Update bat.yml * Update install.ts * Add to path * Update index.ts * Pass in products * Add products input * Update bat.yml * Cache installs * Update bat.yml * Update install.ts * Update install.ts * Update install.ts * Update install.ts * Enable caching * Cache in the right place * Print the key * More display tweaks * Get the key right * Cache * merge changes for v2-beta (#50) * v2-beta bugfix (#52) * adding tests to catch bugs * updating unit tests and source code * updating workflow to use 2nd release * fixing update level logic * update level deps script workaround * testing no-op on existing install * add output * Update bat.yml * Update bat.yml * Update bat.yml * Update src/matlab.ts Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com> * Update matlab.Release and removed usExisting from destination * updated release info to fix inconsistency * changed output name to matlabroot * fixng pipeline syntax * missing colon in yml * updating naming and fixing missing simulink in bat workflow * changing some variable names for clarity Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com> * Update release info (#57) * Restrict supported releases (#65) * Add cache input to leverage Github Actions cache for v2 (#73) * added cache-save and updated build. TODO: cache-restore * added cache restore * fixing release type conversion and bool type conversion * add unit tests * fixing path and cache hit issues * add architecture to cache key and fix description * addressed review feedback * updated MatlabPath state 'type' * updated missed copyrights * changing back latest URL * update cache input description * Fix mpm mac windows v2-beta (#77) * no more unzip mpm * test no windows * update url * try with .exe extension? * fail slow * update url * try cacheFile to fix file location * take out bad secrets * undo bad string interp * trying fix linux mac * use runcommand * use runcommand * try to specify directory * error if no runner temp found * Updated to check if sudo command is available * Add tests * Switch to registry.npmjs.org * Clean up change * Update copyright * Update to check if which returns empty string * merge rc0 changes to mpm branch (#83) * initial commit * npm audit fix * add batch to tc * chmod matlab-batch * rearranging chmod * still wrangling chmod * remove pct * remove PCT from defaults * update tests * cache fix for support packages * make sure support packages path is in cachePaths if defined * add log for supportPackagesPath * capitalize release dir * had wrong default dir * testing windows thing * remove log. use tmpdir for windows * applying mpm fixes for mac & windows * initial commit * npm audit fix * add batch to tc * chmod matlab-batch * rearranging chmod * still wrangling chmod * remove pct * remove PCT from defaults * update tests * cache fix for support packages * make sure support packages path is in cachePaths if defined * add log for supportPackagesPath * capitalize release dir * had wrong default dir * testing windows thing * remove log. use tmpdir for windows * applying mpm fixes for mac & windows * Merge windows optimization to v2-rc0 * improve os specific cache dir implemenation * try to link after install * symlink wrong direction? * update toolcache impl * forgot .keep * forgot dist * fix typo * debug * more debug idk * forgot recursive * seeing whatever is going on with .complete file * add tests for windows toolcache optimization * prep for merge * one more update before merge * Update bat.yml to v2-rc0 for build until release * address sam's feedback * address mark's feedback * fix error message * switch statement sugar Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com> * Accept any number of spaces in product list Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com> --------- Co-authored-by: sameagen <sameagen@mathworks.com> Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com> * Update action node version (#84) * init update * update bat.yml * update bat.yml * review comments * updating README in preparation for matlab-actions/setup-matlab@v2 (#88) * Update README.md replacing v1 with v2 * removing text on platform restrictions * replacing a verb * updating the action description * replacing 20b with 21a * updating products description * updating the cache description * adding a placeholder section * adding missing trademark symbol * update the first example description * removing a code block * updating the last example description * addressing review feedback * Fix a typo. Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com> --------- Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com> --------- Co-authored-by: Johan Pereira <2079700+jwpereira@users.noreply.github.com> Co-authored-by: Andy Campbell <acampbel@mathworks.com> Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com> Co-authored-by: sameagen <sameagen@mathworks.com> Co-authored-by: sameagen-MW <122639681+sameagen-MW@users.noreply.github.com> Co-authored-by: mw-hrastega <48831250+mw-hrastega@users.noreply.github.com>

mcafaro and others added 30 commits January 4, 2022 13:19

Only run deps install script on Linux

7a12483

Add macOS and Windows to integ test matrix

8a8f605

Add MATLAB bin folder to runner path after installation

2e54d2d

Merge pull request #23 from matlab-actions/windows-and-macos

8091c47

Add limited, undocumented, Windows and macOS support

Update vulnerable dependencies

1375ca6

Merge pull request #24 from matlab-actions/deps

eef5296

Update vulnerable dependencies

1.1.0

50f16ad

Use BSD license

55c576c

Merge pull request #36 from matlab-actions/bsd

40d866d

Use BSD license

Merge pull request #34 from matlab-actions/dependabot/npm_and_yarn/mi…

7f1fdda

…nimist-1.2.6 Bump minimist from 1.2.5 to 1.2.6

1.1.1

46e7daa

initial commit mpm

2e665de

fixing async issues

ad431e0

figuring out how actions cache paths works

0a1176c

moving cache find inside mpm call

ddf6c8e

trying once more with cache path

5099d96

Add matlab-batch and --skip-activation (#40)

f8c7a05

* skips ematlab activation if MATHWORKS env vars are set * added matlab-batch install

Update release process to automate semantic versioning (#41)

f0e45fe

* update release.yml to update semantic versions

[skip ci] Bump v1.2.0

0b67291

linking to the run-build documentation (#43)

ee31f66

linking to the run-build documentation

Davidb/mpm (#45)

a8893fd

merging from fork

fixing merge conflicts with main

bacc53a

[skip ci] Bump v1.2.1

63123b7

Bump node version (#47)

d7d39b6

bumping action node version

[skip ci] Bump v1.2.2

71fedd9

Update matlab.ts

07d2345

bumping vulnerable dependencies (#49)

9368315

[skip ci] Bump v1.2.3

6c1f874

davidbuzinski added 5 commits November 8, 2022 09:16

re-syncing recent dependency changes from main

a8947ae

oops forgot a git add

e5eb26e

install MATLAB + PCT by default

f236f47

fixing build

57833da

fixing assert in CI

2c2b042

mcafaro reviewed Nov 8, 2022

View reviewed changes

davidbuzinski added 2 commits November 8, 2022 15:43

address initial feedback

164142e

fixing build

31283dc

mcafaro approved these changes Nov 8, 2022

View reviewed changes

davidbuzinski and others added 2 commits November 9, 2022 14:59

Apply suggestions from code review

65ddcd5

Co-authored-by: Mark Cafaro <34887852+mcafaro@users.noreply.github.com>

changing version info to release info for consistency

f8a9aa5

mw-hrastega reviewed Nov 10, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

mw-hrastega reviewed Nov 10, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

mw-hrastega reviewed Nov 10, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

davidbuzinski commented Nov 10, 2022

View reviewed changes

src/matlab.ts Outdated Show resolved Hide resolved

davidbuzinski commented Nov 10, 2022

View reviewed changes

src/matlab.ts Outdated Show resolved Hide resolved

davidbuzinski added 2 commits November 10, 2022 15:15

updating errors and README

dc44c11

Updating error text

3720cf8

mw-hrastega reviewed Nov 10, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

mw-hrastega reviewed Nov 10, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

mw-hrastega reviewed Nov 10, 2022

View reviewed changes

src/mpm.ts Outdated Show resolved Hide resolved

Incorporating doc feedback

f873f22

mw-hrastega reviewed Nov 11, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

davidbuzinski added 2 commits November 11, 2022 13:24

updating README intro

4baab09

updating examples

6401472

mw-hrastega approved these changes Nov 11, 2022

View reviewed changes

davidbuzinski merged commit db4be46 into mpm Nov 11, 2022

davidbuzinski deleted the davidb/mpm branch November 11, 2022 19:37

Davidb/mpm #50

Davidb/mpm #50

Uh oh!

Conversation

davidbuzinski commented Nov 8, 2022

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!