Fix path uuid lookup bug

[davidanastasov]

Related Issue

#402

Description

This fixes a bug in the detail panel uuid lookup when the rows are grouped

Impacted Areas in Application

The change affects these methods from data-manager.js which are used inside material-table.js

• changeRowSelected
• changeDetailPanelVisibility
• changeGroupExpand
• changeTreeExpand

[Domino987]

Can wee verify that if the 0 is within the oath array, this works as well? I think this change is correct bit not extensive enough, because I think there is still a case where the index is used. And this would break this. I think w would also rwmove all index path elements.

[davidanastasov]

@Domino987 I thought about that case, but I couldn't recreate it with any of the demos, and that's why I thought this would be enough. To be extra safe we could either:

1. Check if the current element from the path array is a number or a string (uuid):
   

2. Try to first get the element based on the index, if that's undefined, try to find it by matching the uuid
   

I personally prefer the second option, do you think it's enough to cover this case?
As for removing the indexes from the path array everywhere, I haven't explored the filtering and grouping logic enough to be able to take on that task at this moment. Is there a benefit to doing that? I also saw in the contributor guidelines that you're planning on rewriting the data-manager global state to use context, is that still the plan?

[Domino987]

Yes the second option is better I think.

It might be caused by tree dat aa well.

But this should work for both sencarios.

Regarding the data-manager, one idea would be to port it to context or recoil but this would be a work of a month at least so I had no time to do that yet.