Detail panel doesn't open when the rows are grouped

[davidanastasov]

#394 breaks the details panel once the rows are grouped by a column. I managed to track the problem down to the following line.

core/src/utils/data-manager.js

Line 571 in 47b7080

return result.data[current];

This bug only exists on the latest version (4.3.10), once I downgraded to 4.3.9, the bug was resolved.

Describe the bug
The bug occurs because the findDataByPath function returns undefined.
If you try to open the details panel while no grouping is active, the path array contains only one integer value, and the details panel opens normally.
If you group the rows by some column, the path array now contains two values, the first one being the group index, and the second one being the unique row id (uuid). The uuid is a string, and result.data["uuid"] returns undefined.

To Reproduce
CodeSandbox

1. Group the rows by the column "Words"
2. Expand the group "Paper"
3. Try to open the details panel for one of the rows inside the "Paper" group
4. The following error will get thrown in the console
   

[Domino987]

Seems like there is a mismatch between the grouping and tree data arrays. Would you mind looking into where the wrong thing comes from ?

[kouraf]

Did i miss something? or the code in the sandbox works very well!

[davidanastasov]

@kouraf Yes, you sorted the values by the column "Word", which should work well.
The bug occurs when you group the rows by the column "Word". To group the rows drag the header of the column "Word" into the group bar, and then try to expand the detail panel.
See the example below:

[davidanastasov]

@Domino987 From what I can see the grouping and data object logic works correctly, I think this bug is connected to the path array. This bug was introduced when this line was changed in #394:

Reverting that change fixes the bug, but it also reverts back to using the index instead of the row uuid for the path.
I think the solution is to look for a uuid match when trying to get the specific object from the data array:

I tested this fix, and it does fix the bug, while also not breaking any other features from what I can see.
Do you think this is a viable fix for this bug? If it is I'd be happy to open a PR for it.

[Domino987]

Yes this looks good. Seems like I missed this Point when I converted it to the id.

A PR would be appreciated.

[matthewoestreich]

Are we good to close this one out?

Edit: it looks like a PR has been merged for this, I will close it out. Please let me know if we need to reopen it.