Skip to content

[TimePicker] Use Material3 icon-only style for input mode button #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[TimePicker] Use Material3 icon-only style for input mode button #2932

wants to merge 1 commit into from

Conversation

pubiqq
Copy link
Contributor

@pubiqq pubiqq commented Aug 22, 2022 •
edited
Loading

Before After

@imhappi imhappi requested a review from paulfthomas August 24, 2022 17:11
@drchen
Copy link
Contributor

drchen commented Aug 30, 2022

We probably need designer's approval for this. @paulfthomas can you give some suggestions how we should proceed here?

@paulfthomas
Copy link
Member

Can you explain the changes?

  • why removing the marginTop?
  • why removing the shapeAppearance?

@pubiqq
Copy link
Contributor Author

pubiqq commented Nov 2, 2022

why removing the marginTop?

@id/barrier already provides the correct margin, additional "fine-tuning" is not needed.

why removing the shapeAppearance?

The correct and consistent shapeAppearance is provided by Widget.Material3.Button.

@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from 3101a47 to 73370af Compare May 15, 2023 18:28
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from 73370af to 3413f5a Compare August 24, 2023 01:57
@pubiqq pubiqq mentioned this pull request Aug 31, 2023
Closed
raajkumars
raajkumars reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@raajkumars raajkumars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pubiqq pubiqq mentioned this pull request Oct 2, 2023
Open
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from 3413f5a to db30136 Compare August 13, 2024 11:35
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from db30136 to e7bb570 Compare September 4, 2024 18:48
@pubiqq
Copy link
Contributor Author

pubiqq commented Oct 18, 2024

It's been two years, there are only four lines changed in the commit and each line is explained, I don't know what else you need 😕.

@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from e7bb570 to 730c146 Compare May 12, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raajkumars raajkumars raajkumars left review comments

@paulfthomas paulfthomas Awaiting requested review from paulfthomas

At least 1 approving review is required to merge this pull request.

Assignees

@paulfthomas paulfthomas

Labels
Awaiting Design Feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pubiqq @drchen @paulfthomas @raajkumars