Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ColorStateListDrawable support #3538

Closed
wants to merge 2 commits into from
Closed

Add ColorStateListDrawable support #3538

wants to merge 2 commits into from

Conversation

pubiqq
Copy link
Contributor

@pubiqq pubiqq commented Aug 23, 2023

No description provided.

@imhappi imhappi requested a review from pekingme August 23, 2023 19:57
pekingme
pekingme requested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@pekingme pekingme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your contribution making Material library better! Left a few comments.

lib/java/com/google/android/material/bottomsheet/BottomSheetDialog.java Show resolved Hide resolved
lib/java/com/google/android/material/appbar/MaterialToolbar.java Outdated Show resolved Hide resolved
lib/java/com/google/android/material/navigation/NavigationBarView.java Outdated Show resolved Hide resolved
lib/java/com/google/android/material/navigation/NavigationBarView.java Show resolved Hide resolved
lib/java/com/google/android/material/navigation/NavigationView.java Outdated Show resolved Hide resolved
lib/java/com/google/android/material/navigation/NavigationView.java Outdated Show resolved Hide resolved
@pekingme pekingme mentioned this pull request Aug 28, 2023
Closed
@pubiqq pubiqq requested a review from pekingme August 30, 2023 19:31
pekingme
pekingme approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@pekingme pekingme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@pekingme pekingme self-assigned this Aug 30, 2023
@pekingme pekingme added the Reviewing Internally An internal change has been created and sent for review. label Aug 30, 2023
@dsn5ft dsn5ft closed this in 0663019 Sep 7, 2023
@leticiarossi leticiarossi removed the Reviewing Internally An internal change has been created and sent for review. label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pekingme pekingme pekingme approved these changes

Assignees

@pekingme pekingme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pubiqq @pekingme @leticiarossi