Skip to content

Improve TypedTasks #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Mar 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
d71df34
Done
sebastianvarela Jun 14, 2022
02aa0b7
Fix
sebastianvarela Jun 14, 2022
2ce006b
Fix CI
sebastianvarela Jun 23, 2022
e0afcbb
Add pending extensions
sebastianvarela Jun 23, 2022
938040a
Fix CI
sebastianvarela Jun 23, 2022
e1b1693
Remove trainer
sebastianvarela Jun 23, 2022
b1dfef5
Fastlane
sebastianvarela Jun 23, 2022
77e765e
Fix CI
sebastianvarela Jun 23, 2022
e0a129a
Fix CI
sebastianvarela Jun 24, 2022
6d5e262
Fix Tests
sebastianvarela Jun 24, 2022
63bbb70
Use Legacy build
sebastianvarela Jun 24, 2022
c895dbd
Merge branch 'master' into typedtasks
sebastianvarela Jun 24, 2022
63224e8
Solve warnings
sebastianvarela Jun 24, 2022
89bdd4f
WIP
sebastianvarela Jun 27, 2022
90d4947
Add WIP Tests
sebastianvarela Jun 27, 2022
f574c90
WIP
sebastianvarela Jun 28, 2022
05dc1ee
Finally!
sebastianvarela Jun 28, 2022
c65b5bb
Improve payload actions
sebastianvarela Jun 28, 2022
a0d876f
DONE
sebastianvarela Jun 28, 2022
bfba166
Finish
sebastianvarela Jun 28, 2022
b37314c
Delete WorkspaceSettings.xcsettings
sebastianvarela Jun 29, 2022
46ddd34
Fix CI
sebastianvarela Jun 29, 2022
b5a5a2e
fix danger
sebastianvarela Jun 29, 2022
689d311
Merge branch 'master' into typedtasks
sebastianvarela Jun 29, 2022
71f1a4e
Move extensions to AnyPublisher instead of Future
sebastianvarela Feb 1, 2023
3887d3a
Succesfully removed Rx!! 🥸
sebastianvarela Feb 28, 2023
4287ac9
Improve EmptyTask with NoneType
sebastianvarela Mar 9, 2023
91979ae
Done!!
sebastianvarela Mar 10, 2023
8a190b1
Enable Codecov
sebastianvarela Mar 10, 2023
050a4b4
Add swiftlint in overcommit
sebastianvarela Mar 10, 2023
1bcdbc0
Code review
sebastianvarela Mar 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-and-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ jobs:

- name: Run all tests ⚙️
run: arch -arm64 rake tests
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

- name: Validate Podfile ⚙️
run: arch -arm64 rake validate_podfile
Expand Down
6 changes: 2 additions & 4 deletions .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ opt_in_rules:
- yoda_condition
- modifier_order
- anyobject_protocol
- unused_import
#- explicit_acl
- cyclomatic_complexity
#style
Expand All @@ -26,7 +25,6 @@ opt_in_rules:
- file_header
- conditional_returns_on_newline
- implicit_return
- explicit_self
- multiline_function_chains
- switch_case_on_newline
- prefer_self_type_over_type_of_self
Expand Down Expand Up @@ -74,8 +72,8 @@ line_length:
warning: 250
error: 400
large_tuple:
warning: 3
error: 3
warning: 5
error: 5
file_length:
warning: 2000
error: 2000
Expand Down
1 change: 0 additions & 1 deletion Cartfile

This file was deleted.

1 change: 0 additions & 1 deletion Cartfile.resolved

This file was deleted.

123 changes: 61 additions & 62 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,36 +1,35 @@
GEM
remote: https://rubygems.org/
specs:
CFPropertyList (3.0.5)
CFPropertyList (3.0.6)
rexml
activesupport (6.1.6)
activesupport (7.0.4.2)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
zeitwerk (~> 2.3)
addressable (2.8.0)
public_suffix (>= 2.0.2, < 5.0)
addressable (2.8.1)
public_suffix (>= 2.0.2, < 6.0)
algoliasearch (1.27.5)
httpclient (~> 2.8, >= 2.8.3)
json (>= 1.5.1)
artifactory (3.0.15)
atomos (0.1.3)
aws-eventstream (1.2.0)
aws-partitions (1.600.0)
aws-sdk-core (3.131.2)
aws-partitions (1.717.0)
aws-sdk-core (3.170.0)
aws-eventstream (~> 1, >= 1.0.2)
aws-partitions (~> 1, >= 1.525.0)
aws-sigv4 (~> 1.1)
aws-partitions (~> 1, >= 1.651.0)
aws-sigv4 (~> 1.5)
jmespath (~> 1, >= 1.6.1)
aws-sdk-kms (1.57.0)
aws-sdk-core (~> 3, >= 3.127.0)
aws-sdk-kms (1.62.0)
aws-sdk-core (~> 3, >= 3.165.0)
aws-sigv4 (~> 1.1)
aws-sdk-s3 (1.114.0)
aws-sdk-core (~> 3, >= 3.127.0)
aws-sdk-s3 (1.119.1)
aws-sdk-core (~> 3, >= 3.165.0)
aws-sdk-kms (~> 1)
aws-sigv4 (~> 1.4)
aws-sigv4 (1.5.0)
aws-sigv4 (1.5.2)
aws-eventstream (~> 1, >= 1.0.2)
babosa (1.0.4)
childprocess (4.1.0)
Expand All @@ -39,26 +38,26 @@ GEM
cork
nap
open4 (~> 1.3)
cocoapods (1.11.3)
cocoapods (1.12.0)
addressable (~> 2.8)
claide (>= 1.0.2, < 2.0)
cocoapods-core (= 1.11.3)
cocoapods-core (= 1.12.0)
cocoapods-deintegrate (>= 1.0.3, < 2.0)
cocoapods-downloader (>= 1.4.0, < 2.0)
cocoapods-downloader (>= 1.6.0, < 2.0)
cocoapods-plugins (>= 1.0.0, < 2.0)
cocoapods-search (>= 1.0.0, < 2.0)
cocoapods-trunk (>= 1.4.0, < 2.0)
cocoapods-trunk (>= 1.6.0, < 2.0)
cocoapods-try (>= 1.1.0, < 2.0)
colored2 (~> 3.1)
escape (~> 0.0.4)
fourflusher (>= 2.3.0, < 3.0)
gh_inspector (~> 1.0)
molinillo (~> 0.8.0)
nap (~> 1.0)
ruby-macho (>= 1.0, < 3.0)
ruby-macho (>= 2.3.0, < 3.0)
xcodeproj (>= 1.21.0, < 2.0)
cocoapods-core (1.11.3)
activesupport (>= 5.0, < 7)
cocoapods-core (1.12.0)
activesupport (>= 5.0, < 8)
addressable (~> 2.8)
algoliasearch (~> 1.0)
concurrent-ruby (~> 1.1)
Expand All @@ -80,28 +79,28 @@ GEM
colored2 (3.1.2)
commander (4.6.0)
highline (~> 2.0.0)
concurrent-ruby (1.1.10)
concurrent-ruby (1.2.2)
cork (0.3.0)
colored2 (~> 3.1)
danger (8.6.1)
danger (9.2.0)
claide (~> 1.0)
claide-plugins (>= 0.9.2)
colored2 (~> 3.1)
cork (~> 0.1)
faraday (>= 0.9.0, < 2.0)
faraday (>= 0.9.0, < 3.0)
faraday-http-cache (~> 2.0)
git (~> 1.7)
kramdown (~> 2.3)
kramdown-parser-gfm (~> 1.0)
no_proxy_fix
octokit (~> 4.7)
octokit (~> 5.0)
terminal-table (>= 1, < 4)
danger-junit (1.0.2)
danger (> 2.0)
ox (~> 2.0)
danger-plugin-api (1.0.0)
danger (> 2.0)
danger-swiftlint (0.30.2)
danger-swiftlint (0.31.0)
danger
rake (> 10)
thor (~> 0.19)
Expand All @@ -118,13 +117,13 @@ GEM
rake (>= 12.0.0, < 14.0.0)
domain_name (0.5.20190701)
unf (>= 0.0.5, < 1.0.0)
dotenv (2.7.6)
dotenv (2.8.1)
emoji_regex (3.2.3)
escape (0.0.4)
ethon (0.15.0)
ethon (0.16.0)
ffi (>= 1.15.0)
excon (0.92.3)
faraday (1.10.0)
excon (0.99.0)
faraday (1.10.3)
faraday-em_http (~> 1.0)
faraday-em_synchrony (~> 1.0)
faraday-excon (~> 1.1)
Expand All @@ -142,7 +141,7 @@ GEM
faraday-em_http (1.0.0)
faraday-em_synchrony (1.0.0)
faraday-excon (1.1.0)
faraday-http-cache (2.4.0)
faraday-http-cache (2.4.1)
faraday (>= 0.8)
faraday-httpclient (1.0.1)
faraday-multipart (1.0.4)
Expand All @@ -155,7 +154,7 @@ GEM
faraday_middleware (1.2.0)
faraday (~> 1.0)
fastimage (2.2.6)
fastlane (2.206.2)
fastlane (2.212.1)
CFPropertyList (>= 2.3, < 4.0.0)
addressable (>= 2.8, < 3.0.0)
artifactory (~> 3.0)
Expand Down Expand Up @@ -198,11 +197,12 @@ GEM
fourflusher (2.3.1)
fuzzy_match (2.0.4)
gh_inspector (1.1.3)
git (1.11.0)
git (1.14.0)
addressable (~> 2.8)
rchardet (~> 1.8)
google-apis-androidpublisher_v3 (0.22.0)
google-apis-core (>= 0.5, < 2.a)
google-apis-core (0.6.0)
google-apis-androidpublisher_v3 (0.34.0)
google-apis-core (>= 0.9.1, < 2.a)
google-apis-core (0.11.0)
addressable (~> 2.5, >= 2.5.1)
googleauth (>= 0.16.2, < 2.a)
httpclient (>= 2.8.1, < 3.a)
Expand All @@ -211,27 +211,27 @@ GEM
retriable (>= 2.0, < 4.a)
rexml
webrick
google-apis-iamcredentials_v1 (0.12.0)
google-apis-core (>= 0.6, < 2.a)
google-apis-playcustomapp_v1 (0.9.0)
google-apis-core (>= 0.6, < 2.a)
google-apis-storage_v1 (0.15.0)
google-apis-core (>= 0.5, < 2.a)
google-apis-iamcredentials_v1 (0.17.0)
google-apis-core (>= 0.11.0, < 2.a)
google-apis-playcustomapp_v1 (0.13.0)
google-apis-core (>= 0.11.0, < 2.a)
google-apis-storage_v1 (0.19.0)
google-apis-core (>= 0.9.0, < 2.a)
google-cloud-core (1.6.0)
google-cloud-env (~> 1.0)
google-cloud-errors (~> 1.0)
google-cloud-env (1.6.0)
faraday (>= 0.17.3, < 3.0)
google-cloud-errors (1.2.0)
google-cloud-storage (1.36.2)
google-cloud-errors (1.3.0)
google-cloud-storage (1.44.0)
addressable (~> 2.8)
digest-crc (~> 0.4)
google-apis-iamcredentials_v1 (~> 0.1)
google-apis-storage_v1 (~> 0.1)
google-apis-storage_v1 (~> 0.19.0)
google-cloud-core (~> 1.6)
googleauth (>= 0.16.2, < 2.a)
mini_mime (~> 1.0)
googleauth (1.1.3)
googleauth (1.3.0)
faraday (>= 0.17.3, < 3.a)
jwt (>= 1.4, < 3.0)
memoist (~> 0.16)
Expand All @@ -242,20 +242,20 @@ GEM
http-cookie (1.0.5)
domain_name (~> 0.5)
httpclient (2.8.3)
i18n (1.10.0)
i18n (1.12.0)
concurrent-ruby (~> 1.0)
iniparse (1.5.0)
jmespath (1.6.1)
json (2.6.2)
jwt (2.4.1)
jmespath (1.6.2)
json (2.6.3)
jwt (2.7.0)
kramdown (2.4.0)
rexml
kramdown-parser-gfm (1.1.0)
kramdown (~> 2.0)
memoist (0.16.2)
mini_magick (4.11.0)
mini_magick (4.12.0)
mini_mime (1.1.2)
minitest (5.16.1)
minitest (5.17.0)
molinillo (0.8.0)
multi_json (1.15.0)
multipart-post (2.0.0)
Expand All @@ -264,18 +264,18 @@ GEM
naturally (2.2.1)
netrc (0.11.0)
no_proxy_fix (0.1.2)
octokit (4.25.0)
octokit (5.6.1)
faraday (>= 1, < 3)
sawyer (~> 0.9)
open4 (1.3.4)
optparse (0.1.1)
os (1.1.4)
overcommit (0.59.1)
overcommit (0.60.0)
childprocess (>= 0.6.3, < 5)
iniparse (~> 1.4)
rexml (~> 3.2)
ox (2.14.11)
plist (3.6.0)
ox (2.14.14)
plist (3.7.0)
public_suffix (4.0.7)
rake (13.0.6)
rchardet (1.8.0)
Expand All @@ -293,12 +293,12 @@ GEM
addressable (>= 2.3.5)
faraday (>= 0.17.3, < 3)
security (0.1.3)
signet (0.16.1)
signet (0.17.0)
addressable (~> 2.8)
faraday (>= 0.17.5, < 3.0)
faraday (>= 0.17.5, < 3.a)
jwt (>= 1.5, < 3.0)
multi_json (~> 1.10)
simctl (1.6.8)
simctl (1.6.10)
CFPropertyList
naturally
slack-notifier (2.4.0)
Expand All @@ -313,14 +313,14 @@ GEM
tty-cursor (~> 0.7)
typhoeus (1.4.0)
ethon (>= 0.9.0)
tzinfo (2.0.4)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
uber (0.1.0)
unf (0.1.4)
unf_ext
unf_ext (0.0.8.2)
unicode-display_width (1.8.0)
webrick (1.7.0)
webrick (1.8.1)
word_wrap (1.0.0)
xcodeproj (1.22.0)
CFPropertyList (>= 2.3.3, < 4.0)
Expand All @@ -343,7 +343,6 @@ GEM
xcpretty-travis-formatter (1.0.1)
xcpretty (~> 0.2, >= 0.0.7)
xcresult (0.2.1)
zeitwerk (2.6.0)

PLATFORMS
ruby
Expand Down
2 changes: 0 additions & 2 deletions MasMini-Swift.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ Pod::Spec.new do |s|

s.frameworks = 'Foundation'

s.dependency('RxSwift', '~> 6')

s.default_subspec = 'Core'

s.module_name = 'Mini'
Expand Down
Loading