Skip to content

Improve TypedTasks #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Mar 13, 2023
Merged

Improve TypedTasks #5

merged 31 commits into from
Mar 13, 2023

Conversation

sebastianvarela
Copy link
Collaborator

@sebastianvarela sebastianvarela commented Jun 14, 2022

PR's key points

  • Remove Rx!
  • Improve payload of each task by sending it on success

How to review this PR?

@sebastianvarela sebastianvarela self-assigned this Jun 14, 2022
@ThorBot
Copy link

ThorBot commented Jun 23, 2022

1 Warning
⚠️ Big PR, try to keep changes smaller if you can 😜
4 Messages
📖 ⌛️ [output] Slowest test: test_success_task_with_expiration_setted took 3.011 seconds
📖 ⌛️ [iOS] Slowest test: test_success_task_with_expiration_setted took 3.005 seconds
📖 ⌛️ [mac] Slowest test: test_success_task_with_expiration_setted took 3.006 seconds
📖 ⌛️ [tv] Slowest test: test_success_task_with_expiration_setted took 3.007 seconds

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Patch coverage: 65.19% and project coverage change: +0.14 🎉

Comparison is base (9e30f27) 62.12% compared to head (71f1a4e) 62.27%.

❗ Current head 71f1a4e differs from pull request most recent head 1bcdbc0. Consider uploading reports for the commit 1bcdbc0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   62.12%   62.27%   +0.14%     
==========================================
  Files          23       27       +4     
  Lines         697      766      +69     
==========================================
+ Hits          433      477      +44     
- Misses        264      289      +25     
Flag Coverage Δ
ios 62.27% <65.19%> (+0.14%) ⬆️
mac 62.01% <65.19%> (-0.12%) ⬇️
tv 62.01% <65.19%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/ActionReducer.swift 100.00% <ø> (ø)
Sources/StateType.swift 0.00% <0.00%> (ø)
...ces/Utils/Foundation/DispatchQueueExtensions.swift 0.00% <0.00%> (ø)
...urces/Utils/RxSwift/ObservableTypeExtensions.swift 0.00% <0.00%> (ø)
...tils/RxSwift/PrimitiveSequenceTypeExtensions.swift 0.00% <0.00%> (ø)
Sources/Utils/OrderedSet.swift 64.86% <37.50%> (ø)
Tests/Helpers/TestActions.swift 37.50% <37.50%> (ø)
Sources/Dispatcher.swift 72.03% <56.75%> (ø)
Sources/Store.swift 80.00% <71.42%> (ø)
Sources/Utils/Combine/DemandBuffer.swift 75.00% <75.00%> (ø)
... and 17 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sebastianvarela sebastianvarela marked this pull request as ready for review March 9, 2023 22:33
@adrianrl adrianrl self-requested a review March 13, 2023 13:30
adrianrl
adrianrl previously approved these changes Mar 13, 2023
Gabriel-V-Radu
Gabriel-V-Radu previously approved these changes Mar 13, 2023
@sebastianvarela sebastianvarela dismissed stale reviews from Gabriel-V-Radu and adrianrl via 1bcdbc0 March 13, 2023 15:56
@sebastianvarela sebastianvarela merged commit 91ef05c into master Mar 13, 2023
@sebastianvarela sebastianvarela deleted the typedtasks branch March 13, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants