Open
Conversation
* Upgrade minimum .Net version to 4.6.2 #4433 * Use TaskCreationOptions.RunContinuationsAsynchronously - Now that min version is .Net 4.6.2 we can use RunContinuationsAsynchronously - Remove some unused code
Resolves #4518
* Ensure reference assemblies are copied to output folders The .NET 6.0 SDK introduced a breaking change meaning that reference assemblies are no longer automatically copied from the intermediate build directory to the output directory. An additional MsBuild property is now required. * Specify VS2022 for reference assembly copy condition --------- Co-authored-by: Bernard Mason <bernard.mason@thinksmartbox.com>
- Upstream changes now require C++17 chromiumembedded/cef@57d7d89#diff-58af91ac84808ba9356ca7821c283cf622d8d67e12751a6781a8465248d10a60
- Page is now rendered quicker than before.
- Runs locally fine if run in isolation
- Builds are failing as missing .Net 6 SDK
- See if specifying a specific SDK as appveyor is failing to build the .net 6 projects
- latestMajor didn't work on appveyor
- Was failing with the same symptoms as #4621 The browser was immediately created then destroyed
… eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81ac. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
* Core - Update CefErrorCode and PermissionRequestType * Apply suggestion from @coderabbitai[bot] Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: Alex Maitland <amaitland@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Core - Upgrade to stdcpp20 - Set NOMINMAX - Change compiler options - Fix compiler errors --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2019-11-06