NetCore - Generate Reference Assemblies building with VS2022

[developersthinksmartbox]

Fixes: #4558

Summary: The .NET 6.0 SDK introduced a breaking change meaning that reference assemblies are no longer automatically copied from the intermediate build directory to the output directory. An additional MsBuild property is now required.

Changes: Included the ProduceReferenceAssemblyInOutDir in all required netcore projects

How Has This Been Tested?
Has been tested using build.ps1 script (VS2022) and building in Visual Studio 2022.
Has not been tested with VS2019 build tools

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Updated documentation

Checklist:

• Tested the code (if applicable)
• Commented my code
• Changed the documentation(if applicable)
• New files have a license disclaimer
• The formatting is consistent with the project (project supports .editorconfig)

[AppVeyorBot]

❌ Build CefSharp 115.3.70-CI4806 failed (commit 893c78725b by @)

[AppVeyorBot]

❌ Build CefSharp 115.3.70-CI4807 failed (commit 869ebd3611 by @)

[developersthinksmartbox]

Hey @amaitland, apologies, I got some build errors in the CI that I'm not getting locally. They seem to relate to the framework CefSharp.sln build(s) that I don't think my code affects. Have I done something wrong?

I will get a machine with VS2019 and make sure I can build the .NET framework and core solutions with my changeset.

[amaitland]

The latest commit to master was built successfully see https://ci.appveyor.com/project/cefsharp/cefsharp/builds/47557098

that I don't think my code affects

Not directly, indirectly the property may have some unintended consequences when using VS2019. The netcore build maybe outputting something into the default bin\obj directory used by Net Framework build. I'm speculating at this point.

It may need to be conditionally set. For a quick test try something like:

<ProduceReferenceAssemblyInOutDir Condition="'$(VisualStudioVersion)'=='17.0'">true</ProduceReferenceAssemblyInOutDir>

[AppVeyorBot]

❌ Build CefSharp 115.3.110-CI4812 failed (commit 3d61c09eee by @)

[AppVeyorBot]

✅ Build CefSharp 115.3.110-CI4813 completed (commit d9b9c94a89 by @)

[developersthinksmartbox]

Thanks @amaitland, a build with that change has successfully run although I'm not totally convinced of the cause of the original failure. I tried building my original changeset with VS2019 on our build server (by invoking build.ps1 with no additional arguments) and it compiled successfully.

My understanding is that the netcore builds use the bin.netcore and obj.netcore directories instead of the conventional bin/obj ones so I'm not sure how this was interacting with the framework builds. Also, looking at the build output of the AppVeyor job I see we start with a git clone (so the environment is clean) and then do the framework build before the netcore one.

Looking at Build CefSharp 115.3.70-CI4807 failed, there is an error in the job at line 120 which indicates the cef runtime package failed to download from the cefsharp-myget feed despite it being listed there:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(131,5): error : The feed 'cefsharp-myget [https://www.myget.org/F/cefsharp/]' lists package 'chromiumembeddedframework.runtime.115.3.7' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again. [C:\projects\cefsharp\CefSharp3.sln]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(131,5): error :   Unable to find package 'chromiumembeddedframework.runtime.115.3.7'. [C:\projects\cefsharp\CefSharp3.sln]

The first build failure also shows this problem. Perhaps this was just a temporary connectivity issue?

I'm happy to leave your recommended change in or take it out and try another build. Whatever you'd prefer. :)

[AppVeyorBot]

❌ Build CefSharp 115.3.110-CI4817 failed (commit 80db52cfa6 by @)

[amaitland]

I'm happy to leave your recommended change in or take it out and try another build.

This looks fine. I've asked GitHub to rebase the changes. If AppVeyor builds pass then I'll merge this.

[AppVeyorBot]

✅ Build CefSharp 115.3.110-CI4826 completed (commit 89cca69b6a by @)

[developersthinksmartbox]

Thanks @amaitland! Me and my company appreciate everything you're doing here. ❤