Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Filter Form to show remove button after the input #9224

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Aug 28, 2023

Problem

The Remove button on filter inputs is confusing when there are more than one input - it's hard to determine if it relates to the input on the left or on the right

And on mobile, the remove button breaks the layout

Solution

  • Move the remove button after the input, so that it comes first in the focus order, and the layout is clearer
  • Change the remove icon so that it is not too close to the clear icon in resettable text inputs
  • automatically focus an input after being added to save 1 click
ezgif.com-video-to-mp4.1.mp4
Before After
127 0 0 1_8000_(iPhone 12 Pro) (1) 127 0 0 1_8000_(iPhone 12 Pro)

@djhi djhi added this to the 4.14.0 milestone Aug 28, 2023
@djhi djhi merged commit 768d8d0 into next Aug 28, 2023
8 checks passed
@djhi djhi deleted the fix-filter-form-reset-button branch August 28, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants