-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: move remove filter button and display it on hover #8217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like it! 👍
IMO this should be an opt-in feature, because it is a regression in terms of accessibility. Besides, if it's a new feature, it should target the next branch. |
I like it! Why do you see it as a regression in accessibility? In my opinion, this feature needs a bit of visual polish on the background and position of the close button, the hover zone, and the tooltip. |
Because you can no longer use the Clear button with keyboard only |
016d154
to
3b2817d
Compare
I make a reservation on 3 points:
|
After thinking about the accessibility regression, we won't move forward with this change. We'll keep the less visually appealing "always on" clear button to remain accessible. thanks for your contribution anyway! |
Superseded by #9224 |
Enregistrement.de.l.ecran.2022-12-01.a.15.08.39.mov