Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redux-devtools-extension trace feature in development mode if available. #3781

Merged
merged 20 commits into from
Oct 8, 2019
Merged

Add redux-devtools-extension trace feature in development mode if available. #3781

merged 20 commits into from
Oct 8, 2019

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Oct 6, 2019 •
edited
Loading

Closes #3658

Creating a new PR identical to #3661 but from a new branch of my fork, to avoid problems with my next branch.

@WiXSL WiXSL mentioned this pull request Oct 6, 2019
Closed
@djhi
Copy link
Collaborator

djhi commented Oct 7, 2019

Thanks!

@djhi djhi requested a review from fzaninotto October 7, 2019 07:54
fzaninotto
fzaninotto requested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must also change the "CustomApp.md" tutorial accordingly.

packages/ra-core/src/createAdminStore.ts Show resolved Hide resolved
@WiXSL
Copy link
Contributor Author

WiXSL commented Oct 7, 2019

I've updated "CustomApp.md" file.

fzaninotto
fzaninotto requested changes Oct 8, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've chosen to document a simpler CoreAdmin component than the one in ra-core, to make it easier to understand. Please follow that same path. Developers who want an exact copy of Coreadmin as a basis for their custmo app can still lok at the source.

docs/CustomApp.md Outdated Show resolved Hide resolved
@WiXSL
Copy link
Contributor Author

WiXSL commented Oct 8, 2019

I've updated the docs as you requested.I hope is ok.
Let me know.

fzaninotto
fzaninotto requested changes Oct 8, 2019
View reviewed changes
docs/CustomApp.md Outdated Show resolved Hide resolved
@WiXSL
Copy link
Contributor Author

WiXSL commented Oct 8, 2019

Ok, I've updated the docs.

@fzaninotto fzaninotto merged commit d03447c into marmelab:next Oct 8, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.0.0 milestone Oct 8, 2019
@WiXSL WiXSL deleted the patch-reduxdev-tools branch October 8, 2019 13:42
heesienooi added a commit to heesienooi/react-admin that referenced this pull request Oct 10, 2019
@heesienooi
Merge branch 'next' into fork
6564576 
* next:
  Fix typos
  Allowing for more fine tuning of Quill without rewriting RichTextInput (marmelab#3714)
  Add redux-devtools-extension trace feature in development mode if available. (marmelab#3781)
  Reorganize Upgrade guide
  Pagination resets after filtering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kmaschta Kmaschta Kmaschta approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@WiXSL @djhi @fzaninotto @Kmaschta