Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing for more fine tuning of Quill without rewriting RichTextInput #3714

Merged
merged 6 commits into from
Oct 9, 2019
Merged

Allowing for more fine tuning of Quill without rewriting RichTextInput #3714

merged 6 commits into from
Oct 9, 2019

Conversation

Sheraff
Copy link
Contributor

@Sheraff Sheraff commented Sep 19, 2019

@Sheraff Sheraff mentioned this pull request Sep 19, 2019
Closed
Kmaschta
Kmaschta reviewed Sep 20, 2019
View reviewed changes
Copy link
Contributor

@Kmaschta Kmaschta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition to the API, thanks!

Just about the punctilious about the naming, I would suggest to rename the prop for something like configureQuill that would be more clear IMO

@Sheraff
Copy link
Contributor Author

Sheraff commented Sep 20, 2019

Just about the punctilious about the naming, I would suggest to rename the prop for something like configureQuill that would be more clear IMO

Done ;-)

@pemoreau pemoreau added this to the 3.0.0 milestone Sep 26, 2019
@fzaninotto fzaninotto modified the milestones: 3.0.0, 3.1.0 Oct 3, 2019
@fzaninotto fzaninotto modified the milestones: 3.1.0, 3.0.0 Oct 9, 2019
@fzaninotto fzaninotto merged commit 7419ff1 into marmelab:next Oct 9, 2019
@fzaninotto
Copy link
Member

Thanks!

heesienooi added a commit to heesienooi/react-admin that referenced this pull request Oct 10, 2019
@heesienooi
Merge branch 'next' into fork
6564576 
* next:
  Fix typos
  Allowing for more fine tuning of Quill without rewriting RichTextInput (marmelab#3714)
  Add redux-devtools-extension trace feature in development mode if available. (marmelab#3781)
  Reorganize Upgrade guide
  Pagination resets after filtering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kmaschta Kmaschta Kmaschta approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Sheraff @fzaninotto @Kmaschta @pemoreau