Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update
<Datagrid>
and<SimpleList>
empty message when a filter is active #10184Update
<Datagrid>
and<SimpleList>
empty message when a filter is active #10184Changes from 12 commits
f033b36
9c8c35f
519f88c
c9e5059
9d34116
a9318d1
3dd16b8
6f002a6
82a74f1
07e4e72
d9f6dd4
7790b68
fc38361
f172633
199fbae
a067733
2f46de6
600f8ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this test in the FilterButton tests file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we test the
<SimpleList>
logic here. I use theFilterButton
's story to be able to test it with writing a new component. Do you prefer I write a new component to render that test ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then, why the SimpleList and not the List? Should we do both? @fzaninotto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, the List?oResults is used by
SimpleList
andDatagrid
, so in theory we should test both. Instead, I added a test forListNoResults
itself.