Update <Datagrid> and <SimpleList> empty message when a filter is active
#10184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Sep 6, 2024
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
fzaninotto
requested changes
Sep 6, 2024
packages/ra-ui-materialui/src/list/SimpleList/SimpleList.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/SimpleList/SimpleList.spec.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
djhi
requested changes
Sep 9, 2024
packages/ra-ui-materialui/src/list/SimpleList/SimpleList.spec.tsx
Outdated
Show resolved
Hide resolved
djhi
reviewed
Sep 9, 2024
| ); | ||
| expect(screen.queryByText('ra.navigation.no_results')).not.toBeNull(); | ||
| }); | ||
|
|
||
| it('should display a message when there is no result but filters applied', async () => { |
There was a problem hiding this comment.
Why isn't this test in the FilterButton tests file?
There was a problem hiding this comment.
Because we test the <SimpleList> logic here. I use the FilterButton's story to be able to test it with writing a new component. Do you prefer I write a new component to render that test ?
There was a problem hiding this comment.
But then, why the SimpleList and not the List? Should we do both? @fzaninotto
There was a problem hiding this comment.
In fact, the List?oResults is used by SimpleList and Datagrid, so in theory we should test both. Instead, I added a test for ListNoResults itself.
djhi
approved these changes
Sep 9, 2024
fzaninotto
approved these changes
Sep 9, 2024
fzaninotto
reviewed
Sep 9, 2024
|
|
||
| export const ListNoResults = memo(() => { | ||
| const translate = useTranslate(); | ||
| const resource = useResourceContext(); | ||
| const { setFilters } = useListController({ resource }); |
There was a problem hiding this comment.
useListContext, not useListController!
I fixed the mistake in 199fbae
fzaninotto
changed the title
No result found message to “No [data] found using the current filters. Clear filters<Datagrid> and <SimpleList> empty message when a filter is active
djhi
approved these changes
Sep 10, 2024
fzaninotto
added a commit
that referenced
this pull request
Oct 29, 2024
## Problem Since #10184, published in 5.2.0, `<SimpleList>` and `<Datagrid>` throw an error when used in standalone mode (i.e., outside of a ListContext) with an empty `data`. ## Solution The problem comes from `ListNoResults`, which reads the `ListContext` to determine if there is an active filter. ## Solution Use the alternative `useListContextWithProps` instead of `useListContext`.
quentin-decre
pushed a commit
to quentin-decre/react-admin
that referenced
this pull request
Nov 13, 2024
## Problem Since marmelab#10184, published in 5.2.0, `<SimpleList>` and `<Datagrid>` throw an error when used in standalone mode (i.e., outside of a ListContext) with an empty `data`. ## Solution The problem comes from `ListNoResults`, which reads the `ListContext` to determine if there is an active filter. ## Solution Use the alternative `useListContextWithProps` instead of `useListContext`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When coming back to a list page with active filters and no results, the default message (“no results found”) is misleading when the active filters aren’t visible enough.
Solution
If the list is empty AND there is an active filter,
To Do
Additional Checks
masterfor a bugfix, ornextfor a feature- [ ] The documentation is up to date