Fix stopReplying for non-function callback values

[murphym18]

@paulfalgout made a good point on May 29, 2015 (see #162)

callbacks may be wrapped via the makeCallback function, so if your callback needs to be wrapped, you will not be able to call stopReplying as it won't have the wrapped callback for comparison.

This behavior seems less than ideal and my pull request would change it so that invoking stopReplying with a non-function callback value removes callback functions that makeCallback created for the said callback value.

I also added a test for calling stopReplying with a non-function callback value.

Note that removeHandler (line 89) checks the _callback property and my changes to makeCallback depend on that.

[paulfalgout]

Thanks for this! A surprisingly elegant fix. @marionettejs/marionette-core ?

[jamiebuilds]

Want to condense this logic into:

function makeCallback(val) {
  var callback = _.isFunction(val) ? val : function() { return val; };
  callback._original = val;
  return callback;
}

Then https://github.com/marionettejs/backbone.radio/blob/master/src/backbone.radio.js#L89 can be simplified to:

    if (
-      (!callback || (callback === event.callback || callback === event.callback._callback)) &&
+      (!callback || (callback === event.callback._original)) &&
       (!context || (context === event.context))
    ) {

[jamiebuilds]

Actually looking at this quickly it looks like our replyOnce implementation is incorrect

See backbone

cc @jmeas @jridgewell.

[jamesplease]

Mhm, Radio's event implementation is outdated, in general.

[blikblum]

Closing in favor of #278