stopReplying is possibly not as selective as it needs to be

[jamesplease]

The possible culprit

Q: do stopComplying and stopReplying work as intended right now? Or do they remove too much?

[jamiebuilds]

Any word on this?

[jamesplease]

If there was there would be more here!

[jamiebuilds]

I don't need ya sass, I thought you had something locally before?

[ianmstew]

Are you considering allowing a complyOnce/replyOnce handler to be nondestructive of permanent handlers? E.g., a complyOnce handler would be added in addition to or temporarily in place of an existing handler?

[jamesplease]

Are you considering allowing a complyOnce/replyOnce handler to be nondestructive of permanent handlers?

Not quite. The problem is that, given some arguments, stopComplying might remove too many handlers. I need to test all of the permutations.

[jamesplease]

Todo:

Add tests for each combination of possible arguments. By my count, there are 8 combinations

a, b, c
undefined, undefined, undefined

a, b, undefined
a, undefined, c
undefined, b, c

a, undefined, undefined
undefined, b, undefined
undefined, undefined, c

[jamiebuilds]

You should write a single test in a loop that goes through each of those since it's difficult to track all of the variations.

[paulfalgout]

So one related issue:

callbacks may be wrapped via the makeCallback function, so if your callback needs to be wrapped, you will not be able to call stopReplying as it won't have the wrapped callback for comparison.

https://github.com/marionettejs/backbone.radio/blob/master/src/backbone.radio.js#L331