Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang 13.0.1 #939

Merged
merged 5 commits into from
Sep 2, 2022
Merged

Fix clang 13.0.1 #939

merged 5 commits into from
Sep 2, 2022

Conversation

XapaJIaMnu
Copy link
Contributor

Description

compilation with clang 13.0.1 fails due to set but unused value:

[ 53%] Building CXX object src/CMakeFiles/marian.dir/training/graph_group_async.cpp.o
cd marian-dev/build/src && /usr/bin/clang++ -DBLAS_FOUND=1 -DBUILD_INFO_AVAILABLE=1 -DCOMPILE_CPU=1 -DDETERMINISTIC=0 -DMKL_FOUND=1 -I/opt/intel/mkl/include -Imarian-dev/src -Imarian-dev/src/. -Imarian-dev/src/3rd_party -Imarian-dev/src/3rd_party/SQLiteCpp/include -Imarian-dev/src/3rd_party/sentencepiece -Imarian-dev/src/3rd_party/sentencepiece/third_party/protobuf-lite -Imarian-dev/src/3rd_party/fbgemm/include -Imarian-dev/src/3rd_party/intgemm -Imarian-dev/build/src/3rd_party/intgemm -Imarian-dev/build/local/include -Imarian-dev/src/3rd_party/intgemm/. -std=c++11 -pthread  -fPIC -Wno-unused-result -Wno-unknown-warning-option -Wno-unknown-cuda-version -march=native  -DUSE_SENTENCEPIECE -DMKL_ILP64 -m64 -O3 -m64 -funroll-loops -g  -Wall -Werror -Wextra -Wno-unused-result -Wno-deprecated -Wno-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-value -Wno-unknown-pragmas -Wno-sign-compare -Wno-missing-field-initializers -std=gnu++17 -MD -MT src/CMakeFiles/marian.dir/training/graph_group_async.cpp.o -MF CMakeFiles/marian.dir/training/graph_group_async.cpp.o.d -o CMakeFiles/marian.dir/training/graph_group_async.cpp.o -c marian-dev/src/training/graph_group_async.cpp
In file included from marian-dev/src/training/graph_group_async.cpp:1:
In file included from marian-dev/src/training/graph_group_async.h:4:
In file included from marian-dev/src/training/graph_group.h:9:
In file included from marian-dev/src/training/scheduler.h:7:
marian-dev/src/training/communicator.h:133:11: error: variable 'pos' set but not used [-Werror,-Wunused-but-set-variable]
      int pos = 0;
          ^
1 error generated.
make[2]: *** [src/CMakeFiles/marian.dir/build.make:1154: src/CMakeFiles/marian.dir/training/graph_group_async.cpp.o] Error 1
make[2]: Leaving directory 'marian-dev/build'
make[1]: *** [CMakeFiles/Makefile2:334: src/CMakeFiles/marian.dir/all] Error 2
make[1]: Leaving directory 'marian-dev/build'
make: *** [Makefile:156: all] Error 2

This PR fixes the issue.

Checklist

  • I have tested the code manually
  • I have run regression tests
  • I have read and followed CONTRIBUTING.md
  • I have updated CHANGELOG.md

@XapaJIaMnu XapaJIaMnu requested a review from snukky June 4, 2022 15:27
@snukky
Copy link
Member

snukky commented Jun 6, 2022

Thanks, Nick! Looks like a subset of changes proposed in #936, which seem to fix more compatibility issues with newer clang, so I would propose closing this PR and pulling the other.

@snukky snukky merged commit 3bd281c into master Sep 2, 2022
@snukky snukky deleted the clang_compat branch September 6, 2022 07:26
emjotde pushed a commit that referenced this pull request Oct 4, 2022
macos-10.15 will become unsupported in December 2022. Changes:
* Upgrade Azure DevOps to macos-12
* Pull marian-nmt/sentencepiece#14
* Fix clang 13 errors as in #939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants