Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some warnings on clang 15 that are promoted into errors #936

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Jun 3, 2022

Description

When building with Clang 15 its diagnostics detects some issues in the code that are promoted into errors.

List of changes:

  • removed some unused variables
  • ...
  • ...

Added dependencies: none

How to test

Install clang-15 from its official deb repo and build with it, setting CMake to use it.

Checklist

  • I have tested the code manually
  • I have run regression tests
  • I have read and followed CONTRIBUTING.md
  • I have updated CHANGELOG.md - minor change, not needed

@snukky snukky mentioned this pull request Jun 6, 2022
4 tasks
Copy link
Member

@snukky snukky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snukky snukky merged commit 6250cd8 into marian-nmt:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants