Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust (port / land) Top Banners and add secondary text view #404

Merged
merged 3 commits into from
Oct 20, 2017

Conversation

danesfeder
Copy link
Contributor

@danesfeder danesfeder commented Oct 19, 2017

  • Adds a secondary text view
  • Better adjust TextViews based on what info we get from the given RouteProgress

Todo:

  • Add new logic for data extraction
  • Clean-up and missing javadoc

cc @ericrwolfe

@danesfeder danesfeder added feature New feature request. ⚠️ DO NOT MERGE PR should not be merged! labels Oct 19, 2017
@danesfeder danesfeder added this to the v0.7.0 milestone Oct 19, 2017
@danesfeder danesfeder self-assigned this Oct 19, 2017
@danesfeder danesfeder changed the title Adjust (port / land) and add secondary text view Adjust (port / land) Top Banners and add secondary text view Oct 19, 2017
@danesfeder
Copy link
Contributor Author

device-2017-10-19-173835

@danesfeder danesfeder added ✓ ready for review and removed ⚠️ DO NOT MERGE PR should not be merged! labels Oct 20, 2017
@danesfeder danesfeder merged commit d8638e1 into master Oct 20, 2017
@danesfeder danesfeder deleted the dan-banner-upgrade branch October 20, 2017 18:49
Grsmto pushed a commit to Grsmto/mapbox-navigation-android that referenced this pull request Oct 23, 2017
* master: (36 commits)
  Add bearing for each waypoint (mapbox#408)
  Adjust (port / land) Top Banners and add secondary text view (mapbox#404)
  Release 0.6.3 (mapbox#386)
  Add feedback method (mapbox#392)
  Project clean up (mapbox#397)
  limit routeline GeoJSON to maxzoom 16 to avoid creating more clipping mask for high zoom levels (mapbox#391)
  API Voice instructions (mapbox#394)
  MAS 3.0 (mapbox#373)
  Convert NavigationView to View  (mapbox#346)
  only raw location in metrics (mapbox#349)
  only reroute once users traveled past 50 meters (mapbox#347)
  Account for different landscape view when adjusting drawable colors API 19 and below (mapbox#343)
  Send empty arrays properly (mapbox#354)
  send feedback identifier when the event happens (mapbox#359)
  Add Null check on the notification manager (mapbox#332)
  fix hardcoded feedback id generating a new one on each navigation session (mapbox#352)
  fixed broken link to test app in documentation (mapbox#357)
  adjusted readme to 0.6.2 (mapbox#333)
  Release v0.6.2 (mapbox#324)
  reroute metric (mapbox#296)
  ...

# Conflicts:
#	app/src/main/java/com/mapbox/services/android/navigation/testapp/activity/MockNavigationActivity.java
#	navigation/libandroid-navigation/build.gradle
#	navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/DefaultMilestones.java
#	navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/offroute/OffRouteDetector.java
#	scripts/release.py
This was referenced Oct 24, 2017
@danesfeder danesfeder mentioned this pull request Nov 13, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants