Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[build, node] Bump macos CI job to Node 8 & Xcode 10.2.1 #14653

Merged
merged 1 commit into from
May 28, 2019
Merged

[build, node] Bump macos CI job to Node 8 & Xcode 10.2.1 #14653

merged 1 commit into from
May 28, 2019

Conversation

friedbunny
Copy link
Contributor

@friedbunny friedbunny commented May 13, 2019 •
edited
Loading

NodeJS v6 is no longer available on homebrew, so, at @kkaefer’s suggestion, bump to v8. Refs #14650, #14651.

@friedbunny friedbunny added build Node.js node-mapbox-gl-native labels May 13, 2019
@friedbunny friedbunny requested a review from kkaefer May 13, 2019 23:14
@friedbunny friedbunny self-assigned this May 13, 2019
@friedbunny friedbunny requested a review from tmpsantos May 15, 2019 19:14
@friedbunny
Copy link
Contributor Author

Please review when you get a chance, @kkaefer or @tmpsantos.

@friedbunny friedbunny merged commit ad744d6 into master May 28, 2019
@friedbunny friedbunny deleted the friedbunny-bumps-node-macos-to-8-and-10.2.1 branch May 28, 2019 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kkaefer kkaefer kkaefer approved these changes

@tmpsantos tmpsantos Awaiting requested review from tmpsantos

Assignees

@friedbunny friedbunny

Labels
build Node.js node-mapbox-gl-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@friedbunny @kkaefer