Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[build, darwin] Update CircleCI to Xcode 10.2.1 #14650

Merged
merged 2 commits into from
May 13, 2019

Conversation

friedbunny
Copy link
Contributor

Update CircleCI builds to Xcode 10.2.1 — container specs.

/cc @julianrex

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS build macOS Mapbox Maps SDK for macOS labels May 13, 2019
@friedbunny friedbunny added this to the release-mojito milestone May 13, 2019
@friedbunny friedbunny requested a review from julianrex May 13, 2019 19:58
@friedbunny friedbunny self-assigned this May 13, 2019
@friedbunny
Copy link
Contributor Author

Going to skip updating the node-macos-release job, per #14651.

@friedbunny friedbunny requested a review from 1ec5 as a code owner May 13, 2019 21:41
@friedbunny friedbunny requested a review from a team May 13, 2019 21:41
@friedbunny friedbunny force-pushed the friedbunny-updates-circleci-to-xcode-10.2.1 branch from 42f33d2 to 9f649ff Compare May 13, 2019 21:44
@friedbunny friedbunny removed request for a team and 1ec5 May 13, 2019 21:44
@friedbunny
Copy link
Contributor Author

friedbunny commented May 13, 2019

The check-public-symbols script was failing with ENOBUFS because the new CircleCI container updated to NodeJS 12.1.0 (from 11.13.0), which enforces a default buffer limit for execFileSync().

Since we were piping a large JSON file from SourceKitten, we overran the small default buffer — cd24f4c sets the buffer back to Infinity. This change is tested to be backwards compatible with Node 8, 10, and 11.

$ #!/bin/bash -eo pipefail
make darwin-check-public-symbols
^D��^D��node platform/darwin/scripts/check-public-symbols.js macOS iOS
Installing SourceKitten via Homebrew…
child_process.js:652
    throw err;
    ^

Error: spawnSync sourcekitten ENOBUFS
    at Object.spawnSync (internal/child_process.js:1020:20)
    at spawnSync (child_process.js:616:24)
    at execFileSync (child_process.js:644:15)
    at hasMissingSymbols (/Users/distiller/project/platform/darwin/scripts/check-public-symbols.js:21:16)
    at Object.<anonymous> (/Users/distiller/project/platform/darwin/scripts/check-public-symbols.js:72:16)
    at Module._compile (internal/modules/cjs/loader.js:759:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
    at Module.load (internal/modules/cjs/loader.js:628:32)
    at Function.Module._load (internal/modules/cjs/loader.js:555:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:824:10)
make: *** [darwin-check-public-symbols] Error 1
Exited with code 2

@friedbunny friedbunny force-pushed the friedbunny-updates-circleci-to-xcode-10.2.1 branch from 9f649ff to cd24f4c Compare May 13, 2019 22:13
@friedbunny friedbunny merged commit cd24f4c into master May 13, 2019
@friedbunny friedbunny deleted the friedbunny-updates-circleci-to-xcode-10.2.1 branch May 13, 2019 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants