Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Support Xcode 12 by excluding arm64 simulators and bumping Telemetry to 0.10.4 #458

Merged
merged 9 commits into from
Sep 17, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prep for telemetry 0.10.4 [skip ci]
  • Loading branch information
Julian Rex committed Sep 17, 2020
commit 583ea78d8b85d678ec1404d3c934ce937eff79fe
2 changes: 1 addition & 1 deletion Cartfile
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
binary "https://api.mapbox.com/downloads/v2/carthage/mobile-maps-gl-core/mapbox-ios-sdk-gl-core-static.json" == 5.0.1
github "mapbox/mapbox-events-ios" "fred/carthage-fix"
github "mapbox/mapbox-events-ios" ~> 0.10.4
4 changes: 0 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ export TARGET_BRANCH ?= master

CMAKE ?= cmake

XCODE_VERSION := $(shell xcrun xcodebuild -version | head -1 | awk '{print $2}')
BETA := $(if $(filter $(XCODE_VERSION),12.0),true,false)


ifeq ($(BUILDTYPE), Release)
else ifeq ($(BUILDTYPE), RelWithDebInfo)
else ifeq ($(BUILDTYPE), Sanitize)
Expand Down
10 changes: 8 additions & 2 deletions platform/ios/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@

Mapbox welcomes participation and contributions from everyone. Please read [CONTRIBUTING.md](../../CONTRIBUTING.md) to get started.

## 6.2.0
## master

### 🔧 Dependencies

* Removed Xcode 12/Carthage `lipo` error workaround by updating `mapbox-events-ios` to `~> 0.10.4`.([#458](https://github.com/mapbox/mapbox-gl-native-ios/pull/458))

## 6.2.0 - September 17, 2020

**This release supports iOS 14 and Xcode 12**

Expand All @@ -29,7 +35,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT
### 🔧 Dependencies

* Core library updated to `5.0.1`. ([#438](https://github.com/mapbox/mapbox-gl-native-ios/pull/453))
* `mapbox-events-ios` versioning updated to `~> 0.10.2`.
* `mapbox-events-ios` versioning updated to `~> 0.10.3`.
julianrex marked this conversation as resolved.
Show resolved Hide resolved

## 6.1.0 - August 26, 2020

Expand Down
2 changes: 1 addition & 1 deletion platform/ios/Mapbox-iOS-SDK-snapshot-dynamic.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ Pod::Spec.new do |m|

m.preserve_path = '**/*.bcsymbolmap'

m.dependency "MapboxMobileEvents", "~> 0.10.2"
m.dependency "MapboxMobileEvents", "~> 0.10.4"

end
2 changes: 1 addition & 1 deletion platform/ios/Mapbox-iOS-SDK-stripped.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ Pod::Spec.new do |m|

m.preserve_path = '**/*.bcsymbolmap'

m.dependency "MapboxMobileEvents", "~> 0.10.2"
m.dependency "MapboxMobileEvents", "~> 0.10.4"

end
2 changes: 1 addition & 1 deletion platform/ios/Mapbox-iOS-SDK.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ Pod::Spec.new do |m|

m.preserve_path = '**/*.bcsymbolmap'

m.dependency "MapboxMobileEvents", "~> 0.10.2"
m.dependency "MapboxMobileEvents", "~> 0.10.4"
end
14 changes: 3 additions & 11 deletions platform/ios/scripts/package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ DERIVED_DATA=build/ios
PRODUCTS=${DERIVED_DATA}/Build/Products
LOG_PATH=build/xcodebuild-$(date +"%Y-%m-%d_%H%M%S").log

XCODE_VERSION=`xcrun xcodebuild -version | head -1 | awk '{print $2}'`

BUILD_FOR_DEVICE=${BUILD_DEVICE:-true}
BUILD_DOCS=${BUILD_DOCS:-true}
SYMBOLS=${SYMBOLS:-YES}
Expand Down Expand Up @@ -79,16 +77,10 @@ if [[ ${BUILD_STATIC} == true ]]; then
fi

XCCONFIG=''
if [[ "${XCODE_VERSION}" == "12.0" ]]; then
xcconfig='xcode-12-beta-fix.xcconfig'
echo "Xcode 12 detected, using ${xcconfig}"
if [[ ! -z "${CI:=}" ]]; then
xcconfig='platform/darwin/ci.xcconfig'
echo "CI environment, using ${xcconfig}"
XCCONFIG="-xcconfig ./${xcconfig}"
else
if [[ ! -z "${CI:=}" ]]; then
xcconfig='platform/darwin/ci.xcconfig'
echo "CI environment, using ${xcconfig}"
XCCONFIG="-xcconfig ./${xcconfig}"
fi
fi

mkdir -p build/ios
Expand Down
4 changes: 0 additions & 4 deletions xcode-12-beta-fix.xcconfig

This file was deleted.