Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Support Xcode 12 by excluding arm64 simulators and bumping Telemetry to 0.10.4 #458

Merged
merged 9 commits into from
Sep 17, 2020

Conversation

nagineni
Copy link
Contributor

@nagineni nagineni commented Sep 17, 2020

Carthage build fix for testing.

Preparation for release 6.2.0. This PR:

@nagineni nagineni changed the title [draft] Test carthage build with MME [draft] Test carthage build fix Sep 17, 2020
Copy link
Contributor

@neelmistry94 neelmistry94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled your branch and ran make iproj and make iOS and everything built as expected

@nagineni
Copy link
Contributor Author

@neelmistry94 thanks for the verification.

@nagineni nagineni requested a review from a team September 17, 2020 15:11
@julianrex julianrex changed the title [draft] Test carthage build fix Support Xcode 12 by excluding arm64 simulators and bumping Telemetry to 0.10.4 Sep 17, 2020
@julianrex julianrex requested review from fabian-guerra and removed request for a team September 17, 2020 20:05
platform/ios/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using Xcode 11.7 and Xcode12 GA 209 and works fine. Thank you!

@julianrex julianrex merged commit 4968bf6 into master Sep 17, 2020
@julianrex julianrex deleted the bump-mme-0.10.3-1 branch September 17, 2020 21:38
fabian-guerra pushed a commit that referenced this pull request Sep 17, 2020
…to 0.10.4 (#458)

* [test] Test build fix with MME 0.10.3 with Xcode 12

* Prep for telemetry 0.10.4 [skip ci]

* Some additional tweaks. [skip ci]

* Add Excluded archs

* Update telemetry to 0.10.4

* Remove change log entries introduced from gl-native 5.0.0

* Bump build number

* Cleaned up change log

* Re-add constrain mode.

Co-authored-by: Julian Rex <julian.rex@mapbox.com>
fabian-guerra added a commit that referenced this pull request Sep 17, 2020
* Support Xcode 12 by excluding arm64 simulators and bumping Telemetry to 0.10.4 (#458)

* [test] Test build fix with MME 0.10.3 with Xcode 12

* Prep for telemetry 0.10.4 [skip ci]

* Some additional tweaks. [skip ci]

* Add Excluded archs

* Update telemetry to 0.10.4

* Remove change log entries introduced from gl-native 5.0.0

* Bump build number

* Cleaned up change log

* Re-add constrain mode.

Co-authored-by: Julian Rex <julian.rex@mapbox.com>

* Trigger build

Co-authored-by: Sudarsana Babu Nagineni <sudarsana.babu@mapbox.com>
Co-authored-by: Julian Rex <julian.rex@mapbox.com>
katydecorah pushed a commit that referenced this pull request Sep 30, 2020
* master:
  Made changes to podspec for Xcode 12 build issues  (#482)
  Fix frame-delay bug affect UIViews. (#483)
  Bump sdk version to 6.2.1 (#477)
  Update gl-native to 5.1.0 (#475)
  Fix crash with nil font family name (#476)
  Location manager crash fix when a selector is not implemented (#474)
  Address crash when localFontFamilyName is nil (#467)
  Ensure pending completion blocks, even if rendering is not strictly required. (#463)
  [macos] respect MGLMapSnapshotter on macOS. (#448)
  Support Xcode 12 by excluding arm64 simulators and bumping Telemetry to 0.10.4 (#458)
  Release prep for version 6.2.0 (#453)
  Rename identifer -> identifier (#423)
  Fixed some typos and updated change log (#443)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants