This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 122
Support Xcode 12 by excluding arm64 simulators and bumping Telemetry to 0.10.4 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagineni
changed the title
[draft] Test carthage build with MME
[draft] Test carthage build fix
Sep 17, 2020
neelmistry94
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled your branch and ran make iproj and make iOS and everything built as expected
@neelmistry94 thanks for the verification. |
julianrex
changed the title
[draft] Test carthage build fix
Support Xcode 12 by excluding arm64 simulators and bumping Telemetry to 0.10.4
Sep 17, 2020
julianrex
requested review from
fabian-guerra
and removed request for
a team
September 17, 2020 20:05
knov
reviewed
Sep 17, 2020
fabian-guerra
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using Xcode 11.7 and Xcode12 GA 209 and works fine. Thank you!
fabian-guerra
pushed a commit
that referenced
this pull request
Sep 17, 2020
…to 0.10.4 (#458) * [test] Test build fix with MME 0.10.3 with Xcode 12 * Prep for telemetry 0.10.4 [skip ci] * Some additional tweaks. [skip ci] * Add Excluded archs * Update telemetry to 0.10.4 * Remove change log entries introduced from gl-native 5.0.0 * Bump build number * Cleaned up change log * Re-add constrain mode. Co-authored-by: Julian Rex <julian.rex@mapbox.com>
fabian-guerra
added a commit
that referenced
this pull request
Sep 17, 2020
* Support Xcode 12 by excluding arm64 simulators and bumping Telemetry to 0.10.4 (#458) * [test] Test build fix with MME 0.10.3 with Xcode 12 * Prep for telemetry 0.10.4 [skip ci] * Some additional tweaks. [skip ci] * Add Excluded archs * Update telemetry to 0.10.4 * Remove change log entries introduced from gl-native 5.0.0 * Bump build number * Cleaned up change log * Re-add constrain mode. Co-authored-by: Julian Rex <julian.rex@mapbox.com> * Trigger build Co-authored-by: Sudarsana Babu Nagineni <sudarsana.babu@mapbox.com> Co-authored-by: Julian Rex <julian.rex@mapbox.com>
katydecorah
pushed a commit
that referenced
this pull request
Sep 30, 2020
* master: Made changes to podspec for Xcode 12 build issues (#482) Fix frame-delay bug affect UIViews. (#483) Bump sdk version to 6.2.1 (#477) Update gl-native to 5.1.0 (#475) Fix crash with nil font family name (#476) Location manager crash fix when a selector is not implemented (#474) Address crash when localFontFamilyName is nil (#467) Ensure pending completion blocks, even if rendering is not strictly required. (#463) [macos] respect MGLMapSnapshotter on macOS. (#448) Support Xcode 12 by excluding arm64 simulators and bumping Telemetry to 0.10.4 (#458) Release prep for version 6.2.0 (#453) Rename identifer -> identifier (#423) Fixed some typos and updated change log (#443)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carthage build fix for testing.Preparation for release 6.2.0. This PR:
mapbox-events-ios
to 0.10.4ConstrainMode
was not being set.