Skip to content

Migrate to Swift 5#383

Merged
1ec5 merged 5 commits intomasterfrom
1ec5-swift5
Oct 4, 2019
Merged

Migrate to Swift 5#383
1ec5 merged 5 commits intomasterfrom
1ec5-swift5

Conversation

@1ec5
Copy link
Contributor

@1ec5 1ec5 commented Oct 1, 2019

Migrated to Swift 5 using the migrator in Xcode 11. Replaced the iOS 12.0 build bot with an iOS 13.1 build bot.

/cc @mapbox/navigation-ios

@1ec5 1ec5 added the build label Oct 1, 2019
@1ec5 1ec5 added this to the v0.31.0 milestone Oct 1, 2019
@1ec5 1ec5 requested review from JThramer and frederoni October 1, 2019 05:36
@1ec5 1ec5 self-assigned this Oct 1, 2019
@1ec5
Copy link
Contributor Author

1ec5 commented Oct 1, 2019 

Test Case '-[BridgingTests testRouteOptions]' started.
Could not cast value of type 'NSConcreteValue' (0x7f9fb5016fb0) to '__C.CLLocationCoordinate2D' (0x10bf57f80).
2019-09-30 22:50:07.242782-0700 xctest[11306:28240] Could not cast value of type 'NSConcreteValue' (0x7f9fb5016fb0) to '__C.CLLocationCoordinate2D' (0x10bf57f80).

1ec5 added 2 commits October 1, 2019 09:15
@1ec5
Corrected watchOS version
bf92dd5
@1ec5
Commented out crashing test
e037e4d 
This test will become moot once Objective-C support is removed.
@1ec5
Copy link
Contributor Author

1ec5 commented Oct 1, 2019

I commented out the crashing Objective-C bridging test, since Objective-C support will be removed in #382. In the meantime, note that -[MBRouteOptions initWithCoordinates:profileIdentifier:] cannot be used from Objective-C in Xcode 11.

JThramer
JThramer approved these changes Oct 4, 2019
View reviewed changes
@1ec5 1ec5 merged commit 512cd9a into master Oct 4, 2019
@1ec5 1ec5 deleted the 1ec5-swift5 branch October 4, 2019 01:16
@1ec5 1ec5 mentioned this pull request Oct 30, 2019
Merged
@1ec5 1ec5 mentioned this pull request Dec 28, 2019
Closed
@1ec5 1ec5 modified the milestones: v0.31.0, v1.0 Dec 28, 2019
@1ec5 1ec5 modified the milestones: v1.0.0, v0.31.0 (v0.40) Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frederoni frederoni Awaiting requested review from frederoni

1 more reviewer

@JThramer JThramer JThramer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@1ec5 1ec5

Labels

build

Projects

None yet

Milestone

v0.31.0

Development

Successfully merging this pull request may close these issues.

2 participants

@1ec5 @JThramer