Remove Objective-C compatibility; adopt Swift language features#382
Merged
Remove Objective-C compatibility; adopt Swift language features#382
Conversation
Merged
14 tasks
Contributor
|
This fixes #381. |
This was referenced Sep 27, 2019
Merged
Contributor
|
…and fixes #134. |
JThramer
force-pushed
the
jerrad/objc-delenda-est
branch
from
9e7e860 to
1632a32
Compare
JThramer
force-pushed
the
jerrad/objc-delenda-est
branch
from
75bce56 to
0c7653e
Compare
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
JThramer
commented
Oct 28, 2019
1ec5
reviewed
Oct 30, 2019
1ec5
reviewed
Oct 30, 2019
1ec5
reviewed
Oct 30, 2019
1ec5
reviewed
Oct 30, 2019
1ec5
reviewed
Oct 30, 2019
| let response = options.response(from: json) | ||
| if let routes = response.1 { | ||
| self.postprocess(routes, fetchStartDate: fetchStartDate, responseEndDate: responseEndDate, uuid: json["uuid"] as? String) | ||
| guard let response = possibleResponse, ["application/json", "text/html"].contains(response.mimeType) else { |
Contributor
There was a problem hiding this comment.
Why does this method accept HTML-formatted responses while the other calculate methods only accept JSON?
1ec5
reviewed
Dec 9, 2019
| ignore: | ||
| - "Directions Example" | ||
| - "Tests" | ||
| - "MapboxDirectionsTests" |
Contributor
There was a problem hiding this comment.
#360 originally intended to omit MapboxDirectionsTests from code coverage metrics, but when #362 renamed this folder to Tests, test code inflated test coverage by around 11%. We’ll need to adjust reapply this change in a separate commit outside of this PR to avoid getting dinged by the (justifiable) omission of test code from code coverage metrics.
1ec5
approved these changes
Dec 10, 2019
This was referenced Dec 20, 2019
This was referenced Dec 28, 2019
Closed
This was referenced Aug 28, 2020
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the MapboxDirections.swift-specific companion PR to mapbox/mapbox-navigation-ios#2230.
To-do:
Codable(Adopt Codable and JSONDecoder #221)Fixes #134, fixes #228, and fixes #381.