This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Moving Firebase crash configuration to CI #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
reviewed
Jun 6, 2019
| @@ -46,8 +46,8 @@ android { | |||
| productFlavors { | |||
| global { | |||
| isGlobal = true | |||
| resValue "string", "firebase_app_id", "1:557332920931:android:bdf11618ae45dd61" | |||
| resValue "string", "firebase_api_key", "AIzaSyCGCYLyLoi31Hv-pkBO0D51zCyxjngJbz8" | |||
| resValue "string", "firebase_app_id", System.getenv('FIREBASE_APP_ID') ? System.getenv('FIREBASE_APP_ID') : "blank_place_holder_string" | |||
There was a problem hiding this comment.
What happens if you just have System.getenv('FIREBASE_APP_ID')? (without the ternary expression / default value)
There was a problem hiding this comment.
Build Config field cannot have a null parameter
tobrun
approved these changes
Jun 6, 2019
langsmith
force-pushed
the
ls-firebase-key-fix
branch
from
214f1d1 to
ede7113
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #926 by removing hardcoded values and using BuildConfig instead. The values are now set via CircleCI environment variables.
Using
blank_place_holder_stringmeans thatFIREBASE_APP_IDandFIREBASE_API_KEYdon't have to be set locally to compile the app on a local computer. I'd still advise Mapboxers and others who interact with this app on a frequent basis, to add the following to the Gradle user home folder'sgradle.propertiesfile (similar to https://docs.mapbox.com/help/troubleshooting/private-access-token-android-and-ios/#non-git-option) .cc @zmully @Guardiola31337