replacing hardcoded strings with system environment variable

mapbox · Jun 5, 2019 · 214f1d1 · 214f1d1
1 parent e4cdde7
commit 214f1d1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/MapboxAndroidDemo/build.gradle b/MapboxAndroidDemo/build.gradle
@@ -46,8 +46,8 @@ android {
     productFlavors {
         global {
             isGlobal = true
-            buildConfigField 'String', "firebase_app_id", FIREBASE_API_ID
-            buildConfigField 'String', "firebase_api_key", FIREBASE_API_KEY
+            resValue "string", "firebase_app_id", System.getenv('FIREBASE_APP_ID') ? System.getenv('FIREBASE_APP_ID') : "blank_place_holder_string"
+            resValue "string", "firebase_api_key", System.getenv('FIREBASE_API_KEY') ? System.getenv('FIREBASE_API_KEY') : "blank_place_holder_string"
         }
 
         china {

diff --git a/MapboxAndroidDemo/src/global/java/com/mapbox/mapboxandroiddemo/MapboxApplication.java b/MapboxAndroidDemo/src/global/java/com/mapbox/mapboxandroiddemo/MapboxApplication.java
@@ -22,7 +22,6 @@ public void onCreate() {
     Mapbox.getInstance(this, getString(R.string.access_token));
     Mapbox.getTelemetry().setDebugLoggingEnabled(true);
     setUpTileLoadingMeasurement();
-
   }
 
   private void initializeFirebaseApp() {