onClick fix + new onClose callback#79
Closed
IgorKvasn wants to merge 3 commits intomansona:masterfrom
Closed
Conversation
Contributor
Author
Contributor
|
@IgorKvasn Could you rebase please? |
Contributor
|
@IgorKvasn Going to close this as the branch is significantly out of date now. Please submit an up-to-date PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed, that when onClick callback is defined and user clicks on the close icon, the onClick callback is triggered. I am not sure if it is desired or not, but I don't like this behavior :) Usually close button basically means "ignore the notification and carry on" - by triggering the callback you are basically performing an action that user wanted to ignore.
So I fixed it (onClick callback will be triggered when clicking anywhere on the notification except the close icon) + I added new onClose callback that will be triggered when user closes the notification
btw. I know that the way I fixed the onClick callback in method
mouseDown()is not very nice (jQuery...), but it works anyway...