Skip to content

clicking the close/cancel icon triggers the callback #176

@jondayton

Description

@jondayton

When clicking on the close icon, the onClick callback will be triggered if defined. This seems counterintuitive, as the design and placement makes it should close or cancel the action. It's leading to some strange behavior in our application, where people who are trying to dismiss a link to a page update are instead taken to that page.

detailed here in a PR that seems to have been closed:
#79
Another potential solution is to pass either the event itself or a param that denotes whether or not it was a "dismiss" action, and the result can be handled in the onClick callback itself:
#135

Any plans on incorporating this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions