R 1.2.1

[manolo]

connects to vaadin/components-team-tasks#34

[cwayfinder]

The commit #1 ("Use more reliable way to detect when components are ready") is in master already.

[cwayfinder]

Reviewed 1 of 1 files at r1, 3 of 3 files at r2.
Review status: 3 of 11 files reviewed at latest revision, 2 unresolved discussions.

---

^{gulpfile.js, line 121 [r3] (raw file):}
Please explain this change

---

^{gulpfile.js, line 176 [r3] (raw file):}
Could it be replaced with

    if (helpers.isBehavior(item)) { 
       parseTemplate('Behavior', item, item.is, '', '');
    } else { 
       parseTemplate('Element', item, item.is, '', 'Element');
    }

---

Comments from the review on Reviewable.io

[manolo]

Review status: 3 of 11 files reviewed at latest revision, 2 unresolved discussions.

---

^{gulpfile.js, line 121 [r3] (raw file):}
It's just a aesthetic change, IDE (Eclipse) complains when a property is named as a reserved word although it's legal in js. I dont think it needs any comment in code.

---

^{gulpfile.js, line 176 [r3] (raw file):}
Done.

---

Comments from the review on Reviewable.io

[Saulis]

I'm assuming you've tested this version of the generator with gwt-polymer-elements showcase?

---

Reviewed 1 of 1 files at r1, 2 of 3 files at r2, 2 of 8 files at r3, 1 of 1 files at r4, 4 of 5 files at r5, 1 of 1 files at r8, 2 of 2 files at r9.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

---

^{bin/gwt-api-generator.js, line 12 [r9] (raw file):}
Why isn't package required anymore ?

---

^{gulpfile.js, line 121 [r3] (raw file):}
I'd rather have this as a normal function call. Can't you tell Eclipse to ignore the error?

---

^{gulpfile.js, line 52 [r9] (raw file):}
Redundant done argument.

---

^{lib/com/vaadin/polymer/Polymer.java, line 278 [r9] (raw file):}
Extra whitespace between static and void

---

Comments from the review on Reviewable.io

[manolo]

Yes I've tested it and I'm working using this branch

---

Review status: 12 of 13 files reviewed at latest revision, 5 unresolved discussions.

---

^{bin/gwt-api-generator.js, line 12 [r9] (raw file):}

--package is thought for defining which polymer packages use to generate java classes. Then bower downloads those packages to the resources folder and parses them. That's perfect for predefined projects like we do in gwt-polymer-elements
Though, I want an easier usage. The gwt user just install bower packages in its java project and run the script each time he wants for instance, if I have the showcase project (demo folder) I just do:

$ bower install vaadin/vaadin-grid#master
$ gwt-api-generator

and voila, I have all the grid wrapped and ready in my src/main/java and src/main/resources
So I'm not deprecating --package argument just not making it mandatory

---

^{gulpfile.js, line 121 [r3] (raw file):}
No

---

^{gulpfile.js, line 52 [r9] (raw file):}
Done.

---

^{lib/com/vaadin/polymer/Polymer.java, line 278 [r9] (raw file):}
Done.

---

Comments from the review on Reviewable.io

[Saulis]

Review status: 11 of 13 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

^{bin/gwt-api-generator.js, line 12 [r9] (raw file):}
OK I see now. Would it be a good idea to add a instructions or some sort of a help message when you run gwt-api-generator without --package and don't have a bower_components folder? Because I tried that nothing just happened - didn't get any log messages or nothing that would tell me what's wrong.

---

Comments from the review on Reviewable.io

[manolo]

Review status: 7 of 14 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

^{bin/gwt-api-generator.js, line 12 [r9] (raw file):}
Modified README

---

Comments from the review on Reviewable.io

[Saulis]

Reviewed 1 of 6 files at r12, 1 of 2 files at r18.
Review status: 8 of 14 files reviewed at latest revision, 5 unresolved discussions.

---

^{bin/gwt-api-generator.js, line 12 [r9] (raw file):}
What I had in mind was some kind indicator when you just run the gwt-api-generator without any parameters and bower_components is empty. Currently nothing just happens.

How about adding a console.log messages when generating from a folder? For example: 'No --package provided. Generating 0 package(s) located under bower_components'

---

^{gulpfile.js, line 238 [r18] (raw file):}
I think the else clause could just be if (!args.excludeLib) and the we could get rid of the done argument.

---

^{README.md, line 21 [r18] (raw file):}
missing closing ```

---

Comments from the review on Reviewable.io