Added a pom flag that includes a generic pom.xml to the root #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomivirkki
commented
Jun 10, 2015
tomivirkki
commented
| @@ -199,4 +199,8 @@ gulp.task('copy-files', ['copy:src', 'copy:resources']); | |||
|
|
|||
| gulp.task('default', function(){ | |||
| runSequence('clean', 'bower:install', 'generate', 'copy:lib'); | |||
|
|
|||
| if (args.pom) { | |||
| return gulp.src(__dirname + "/pom/pom.xml").pipe(gulp.dest(process.cwd())); | |||
There was a problem hiding this comment.
I think this should be extracted to a task called copy:pom and the if(args.pom) should be used to decide which tasks to run.
|
Review status:
Comments from the review on Reviewable.io |
all files reviewed, all discussions resolved, all commit checks successful.
Saulis
added a commit
that referenced
this pull request
Jun 11, 2015
Added a pom flag that includes a generic pom.xml to the root
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.