Skip to content

Conversation

@codezninja
Copy link
Contributor

@codezninja codezninja commented Sep 14, 2021

Merge Checklist

  • Have you linked this Pull Request to an Issue?
  • Have you updated any relevant README files, to explain how this new feature works (with examples)?
  • Have you added relevant test cases for your change?
  • Do all tests and code style checks pass with ./gradlew check --info?
  • Have you successfully run your change in a pipeline in a Jenkins instance?
  • Have you updated the CHANGELOG?

Fixes #409

@codezninja codezninja requested a review from kmanning September 14, 2021 19:55
@codezninja codezninja changed the title use latest java9 version use java11 Sep 14, 2021
Copy link
Collaborator

@kmanning kmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you update the CHANGELOG before you merge?

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #410 (f2eaec7) into master (a14c20d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files          53       53           
  Lines        1453     1453           
  Branches      307      307           
=======================================
  Hits         1196     1196           
  Misses        115      115           
  Partials      142      142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14c20d...f2eaec7. Read the comment docs.

@kmanning
Copy link
Collaborator

Looks great, merge when you're ready

@codezninja codezninja merged commit d6d020b into manheim:master Sep 15, 2021
@codezninja codezninja deleted the fix/ci_build branch September 15, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github Actions failing

3 participants