Skip to content

support http/2 client response headers for GithubPRPlugin check #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 20, 2021
Merged

support http/2 client response headers for GithubPRPlugin check #408

merged 6 commits into from
Sep 20, 2021

Conversation

@codezninja
Copy link
Contributor

@codezninja codezninja commented Sep 14, 2021 •
edited
Loading

Merge Checklist

  • Have you linked this Pull Request to an Issue?
  • Have you updated any relevant README files, to explain how this new feature works (with examples)?
  • Have you added relevant test cases for your change?
  • Do all tests and code style checks pass with ./gradlew check --info?
  • Have you successfully run your change in a pipeline in a Jenkins instance?
  • Have you updated the CHANGELOG?

Fixes #407

kmanning
kmanning reviewed Sep 14, 2021
View reviewed changes
@codezninja
Copy link
Contributor Author

codezninja commented Sep 14, 2021

need to merge #410 before we can fix this

@codezninja
Merge remote-tracking branch 'upstream/master' into feature/ghpr_http…
0e14056 
…2_support

* upstream/master:
  update changelog
  use java 11
  use java version 9.0.0+181
  use latest java9 version
@codezninja codezninja marked this pull request as ready for review September 15, 2021 15:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021 •
edited
Loading

Codecov Report

Merging #408 (9a0d980) into master (d6d020b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files          53       53           
  Lines        1453     1453           
  Branches      307      307           
=======================================
  Hits         1196     1196           
  Misses        115      115           
  Partials      142      142
Impacted Files Coverage Δ
src/GithubPRPlanPlugin.groovy 74.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d020b...9a0d980. Read the comment docs.

@codezninja codezninja requested a review from kmanning September 16, 2021 21:30
@codezninja codezninja force-pushed the feature/ghpr_http2_support branch from 3b70475 to 9a0d980 Compare September 17, 2021 11:29
kmanning
kmanning approved these changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@kmanning kmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codezninja codezninja merged commit 19fe5ea into manheim:master Sep 20, 2021
@codezninja codezninja deleted the feature/ghpr_http2_support branch September 20, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jleopold28 jleopold28 jleopold28 left review comments

@kmanning kmanning kmanning approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HTTP/2 201 fails PR Posting

4 participants

@codezninja @codecov-commenter @kmanning @jleopold28