Skip to content

Conversation

@kmanning
Copy link
Collaborator

@kmanning kmanning commented Feb 4, 2021

  • Issue Testing: Upgrade to Junit 5 #332
  • Replace Junit 4 with Junit 5.7
    • JUnit no longer supports assertThat for third-party libraries, so convert org.junit.Assert.assertThat to org.hamcrest.MatcherAssert.assertThat when hamcrest matchers are being used
    • Push towards using hamcrest matchers in general, over JUnit assertions.
    • @Nested in Junit 5 allows us to drop the hierarchicalcontextrunner dependency. Be sure to apply it consistently going forward.
  • Upgrade hamcrest from 1.3 to 2.2
    • Junit 4 pulled in hamcrest dependencies, and Junit 5 no longer does this. Swtich from hamcrest library to hamcrest dependency - this fixes the java.lang.NoSuchMethodError: org/hamcrest/Matcher.describeMismatch errors).

@kmanning kmanning added this to the v5.15 milestone Feb 4, 2021
@kmanning kmanning linked an issue Feb 4, 2021 that may be closed by this pull request
@kmanning kmanning merged commit 9206d7a into manheim:master Feb 4, 2021
@kmanning kmanning deleted the issue_332 branch April 20, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing: Upgrade to Junit 5

1 participant