Skip to content

Issue 300: Trim whitespace when detecting terraform version from file #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2020
Merged

Issue 300: Trim whitespace when detecting terraform version from file #301

merged 3 commits into from
Sep 16, 2020

Conversation

@kmanning
Copy link
Collaborator

@kmanning kmanning commented Sep 16, 2020

  • This was a regression, introduced by v5.12
  • I was attempting to refactor and conslidate the duplicate readFile logic, and used the wrong method.

@kmanning kmanning linked an issue Sep 16, 2020 that may be closed by this pull request
Fix Version Detection: whitespace not trimmed #300
Closed
@kmanning kmanning added this to the v5.12 milestone Sep 16, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #301 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   78.43%   78.43%           
=======================================
  Files          41       41           
  Lines        1048     1048           
  Branches      244      244           
=======================================
  Hits          822      822           
  Misses        105      105           
  Partials      121      121
Impacted Files Coverage Δ
src/TerraformPlugin.groovy 95.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5270f6...a015ee1. Read the comment docs.

@kmanning kmanning requested a review from codezninja September 16, 2020 19:15
codezninja
codezninja approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@codezninja codezninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kmanning kmanning merged commit 90843f2 into manheim:master Sep 16, 2020
@kmanning kmanning deleted the issue_300 branch April 20, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codezninja codezninja codezninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v5.12

Development

Successfully merging this pull request may close these issues.

Fix Version Detection: whitespace not trimmed

3 participants

@kmanning @codecov-commenter @codezninja