Fix Version Detection: whitespace not trimmed

[codezninja]

It looks like when consolidating we removed version trimming. Before the readFile function read the file and removed whitespace. Should we add that logic back OR maybe document it in the release?

terraform-pipeline/src/TerraformPlugin.groovy

Line 33 in a5270f6

version = version ?: Jenkinsfile.original.readFile(TERRAFORM_VERSION_FILE) ?: DEFAULT_VERSION

[kmanning]

Whomp. I think that broke during a refactor. The readFile method was getting copy pasted everywhere, and I'm trying to consolidate it into Jenkinsfile. https://github.com/manheim/terraform-pipeline/blob/master/src/Jenkinsfile.groovy#L120-L127

[codezninja]

hmm based on that it should be trimming it. Let me see if I can find the issue.

[kmanning]

Here's the PR that refactored the code and broke the Plugin - https://github.com/manheim/terraform-pipeline/pull/298/files#diff-2724a09cdd048285c15140f07b77fb5dR33